Skip to content

Comments

[feature] 동아리 지원 api deprecated#1240

Merged
lepitaaar merged 1 commit intodevelop/befrom
feature/#1239-deprecated-application-v1-api-MOA-680
Feb 25, 2026
Merged

[feature] 동아리 지원 api deprecated#1240
lepitaaar merged 1 commit intodevelop/befrom
feature/#1239-deprecated-application-v1-api-MOA-680

Conversation

@lepitaaar
Copy link
Contributor

@lepitaaar lepitaaar commented Feb 25, 2026

#️⃣연관된 이슈

📝작업 내용

ClubApply API 레거시 코드 정리

중점적으로 리뷰받고 싶은 부분(선택)

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

ex) 메서드 XXX의 이름을 더 잘 짓고 싶은데 혹시 좋은 명칭이 있을까요?

논의하고 싶은 부분(선택)

논의하고 싶은 부분이 있다면 작성해주세요.

🫡 참고사항

Summary by CodeRabbit

릴리스 노트

  • 기능 제거
    • 클럽 지원 신청 API 엔드포인트가 제거되었습니다.
    • 클럽 지원서 조회 기능이 제거되었습니다.
    • 지원자 정보 수정 및 삭제 기능이 제거되었습니다.

@lepitaaar lepitaaar self-assigned this Feb 25, 2026
@lepitaaar lepitaaar added ✨ Feature 기능 개발 💾 BE Backend labels Feb 25, 2026
@vercel
Copy link

vercel bot commented Feb 25, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
moadong Ready Ready Preview, Comment Feb 25, 2026 2:47am

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 25, 2026

Warning

.coderabbit.yaml has a parsing error

The CodeRabbit configuration file in this repository has a parsing error and default settings were used instead. Please fix the error(s) in the configuration file. You can initialize chat with CodeRabbit to get help with the configuration file.

💥 Parsing errors (1)
Validation error: Invalid regex pattern for base branch. Received: "**" at "reviews.auto_review.base_branches[0]"
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between aff80a1 and c8b086b.

📒 Files selected for processing (3)
  • backend/src/main/java/moadong/club/controller/ClubApplyControllerV1.java
  • backend/src/main/java/moadong/club/repository/ClubApplicationFormsRepository.java
  • backend/src/main/java/moadong/club/service/ClubApplyServiceV1.java
💤 Files with no reviewable changes (3)
  • backend/src/main/java/moadong/club/service/ClubApplyServiceV1.java
  • backend/src/main/java/moadong/club/controller/ClubApplyControllerV1.java
  • backend/src/main/java/moadong/club/repository/ClubApplicationFormsRepository.java

Walkthrough

클럽 신청 관련 레거시 V1 컴포넌트를 제거하는 리팩토링입니다. 컨트롤러, 서비스, 저장소 메서드 총 3개 파일에서 클럽 신청 워크플로우의 REST 엔드포인트, 비즈니스 로직, 쿼리 메서드 약 300줄을 삭제합니다.

Changes

Cohort / File(s) Summary
클럽 신청 컨트롤러 제거
backend/src/main/java/moadong/club/controller/ClubApplyControllerV1.java
V1 컨트롤러 전체 제거 (95줄): POST /apply, GET /apply/info, PUT /applicant, DELETE /applicant 엔드포인트와 convertClubIdToFormId 헬퍼 메서드 제거. 신청 폼 조회, 신청, 신청자 수정/삭제 기능 완전 제거.
클럽 신청 서비스 제거
backend/src/main/java/moadong/club/service/ClubApplyServiceV1.java
V1 서비스 클래스 전체 제거 (202줄): applyToClub, getClubApplyInfo, editApplicantDetail, deleteApplicant 메서드와 검증/암호화 헬퍼 로직 제거. 클럽 신청 비즈니스 로직의 핵심 구현 완전 제거.
저장소 메서드 제거
backend/src/main/java/moadong/club/repository/ClubApplicationFormsRepository.java
저장소 인터페이스에서 findTopByClubIdAndStatusOrderByEditedAtDesc(String clubId, ApplicationFormStatus status) 메서드 제거 (3줄). 활성 신청 폼 조회 쿼리 메서드 삭제.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested labels

🔨 Refactor, 📬 API

Suggested reviewers

  • Zepelown
  • suhyun113
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed PR 제목이 변경사항의 주요 내용을 명확하게 설명합니다. 레거시 ClubApply API를 제거하는 것이 주요 변경사항이며, 제목에서 "동아리 지원 api deprecated"로 정확하게 반영되어 있습니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/#1239-deprecated-application-v1-api-MOA-680

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

Test Results

99 tests   99 ✅  15s ⏱️
23 suites   0 💤
23 files     0 ❌

Results for commit c8b086b.

Copy link
Member

@seongwon030 seongwon030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lepitaaar lepitaaar merged commit 4f8bc11 into develop/be Feb 25, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💾 BE Backend ✨ Feature 기능 개발

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants