Skip to content

[fix] 소개페이지 a태그 클릭 시 파란색 전환효과 및 밑줄 표시 제거#351

Merged
seongwon030 merged 3 commits intodevelop-fefrom
fix/#350-remove-introducePage-a-tag-clicked-effects-FE-96
Apr 29, 2025
Merged

[fix] 소개페이지 a태그 클릭 시 파란색 전환효과 및 밑줄 표시 제거#351
seongwon030 merged 3 commits intodevelop-fefrom
fix/#350-remove-introducePage-a-tag-clicked-effects-FE-96

Conversation

@seongwon030
Copy link
Member

@seongwon030 seongwon030 commented Apr 28, 2025

#️⃣연관된 이슈

ex) #350

📝작업 내용

  • 부모의 글자색 상속하여 글자색 변경 방지
  • 밑줄 제거

중점적으로 리뷰받고 싶은 부분(선택)

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

ex) 메서드 XXX의 이름을 더 잘 짓고 싶은데 혹시 좋은 명칭이 있을까요?

논의하고 싶은 부분(선택)

논의하고 싶은 부분이 있다면 작성해주세요.

🫡 참고사항

Summary by CodeRabbit

  • Style
    • Introduce 버튼의 링크 색상과 밑줄 스타일이 일관되게 유지되도록 개선되었습니다. 방문한 링크도 동일한 색상과 스타일이 적용됩니다.

@seongwon030 seongwon030 added 🎨 Design 마크업 & 스타일링 💻 FE Frontend 🛠Fix 기능이 의도한 대로 동작하지 않는 버그를 수정 labels Apr 28, 2025
@seongwon030 seongwon030 requested a review from oesnuj April 28, 2025 08:13
@seongwon030 seongwon030 self-assigned this Apr 28, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 28, 2025

Walkthrough

이 변경 사항은 IntroduceButtonStyles 스타일드 컴포넌트의 스타일을 수정하여, a 태그(링크)의 기본 파란색 전환 효과와 밑줄 표시를 제거합니다. 이를 위해 색상을 상속받도록 하고, text-decoration을 제거했으며, 방문한 링크(:visited) 상태에서도 동일한 스타일이 적용되도록 추가 스타일을 지정했습니다. 다른 스타일 속성이나 레이아웃에는 변화가 없습니다.

Changes

파일/경로 변경 요약
frontend/src/components/common/Header/Header.styles.ts IntroduceButtonStyles의 a 태그에 대해 색상 상속 및 밑줄 제거, :visited 상태 추가

Assessment against linked issues

Objective Addressed Explanation
a태그 클릭 시 파란색 전환효 및 밑줄 표시 제거 (FE-96)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@netlify
Copy link

netlify bot commented Apr 28, 2025

Deploy Preview for moadong ready!

Name Link
🔨 Latest commit 7c5cb7c
🔍 Latest deploy log https://app.netlify.com/sites/moadong/deploys/680f389bca58f60008f8f74c
😎 Deploy Preview https://deploy-preview-351--moadong.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 43
Accessibility: 87
Best Practices: 92
SEO: 92
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@seongwon030 seongwon030 changed the title [fix] 소개페이지 a태그 클릭 시 파란색 전환효 및 밑줄 표시 제거 [fix] 소개페이지 a태그 클릭 시 파란색 전환효과 및 밑줄 표시 제거 Apr 28, 2025
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
frontend/src/components/common/Header/Header.styles.ts (2)

74-75: 기본 상태 링크 스타일 재정의
color: inherittext-decoration: none로 기본 링크 스타일을 제거한 점이 적절합니다. 다만 마우스 오버(:hover), 클릭(:active), 포커스(:focus) 상태에서도 동일한 스타일이 적용되는지 확인하거나, 한 번에 그룹으로 처리해 중복을 줄이시길 추천드립니다.

  color: inherit;
  text-decoration: none;
+ &:hover,
+ &:active,
+ &:focus {
+   color: inherit;
+   text-decoration: none;
+ }

77-80: 방문 링크(:visited) 스타일 그룹화 제안
:visited 상태에도 상속된 색상과 밑줄 제거가 적용된 것은 좋습니다. 하지만 별도로 정의하기보다는 위의 상태들과 함께 묶어서 관리하면 코드 중복이 줄고 유지보수가 용이해집니다.

- &:visited {
-   color: inherit;
-   text-decoration: none;
- }
+ &:visited, &:hover, &:active, &:focus {
+   color: inherit;
+   text-decoration: none;
+ }
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bc84fc1 and 7c5cb7c.

📒 Files selected for processing (1)
  • frontend/src/components/common/Header/Header.styles.ts (1 hunks)

Copy link
Member

@oesnuj oesnuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

새탭으로도 잘 열리네용
SEO 최적화 좋습니다 👍

@seongwon030 seongwon030 merged commit 0ac19ac into develop-fe Apr 29, 2025
5 checks passed
@seongwon030 seongwon030 deleted the fix/#350-remove-introducePage-a-tag-clicked-effects-FE-96 branch April 29, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🎨 Design 마크업 & 스타일링 💻 FE Frontend 🛠Fix 기능이 의도한 대로 동작하지 않는 버그를 수정

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[fix] FE-96 소개페이지 a태그 클릭 시 파란색 전환효 및 밑줄 표시 제거

2 participants