Skip to content

[fix] FE-119 SNS 링크 입력 기능 임시 비활성화#428

Merged
oesnuj merged 6 commits intodevelop-fefrom
fix/#427-disable-sns-input-before-release-FE-119
May 18, 2025
Merged

[fix] FE-119 SNS 링크 입력 기능 임시 비활성화#428
oesnuj merged 6 commits intodevelop-fefrom
fix/#427-disable-sns-input-before-release-FE-119

Conversation

@oesnuj
Copy link
Member

@oesnuj oesnuj commented May 18, 2025

#️⃣연관된 이슈

#427

📝작업 내용

이번 PR에서 작업한 내용을 간략히 설명해주세요(이미지/동영상 첨부 가능)
image

  • SNS 링크 입력 기능 아직 배포되지 않은 상태로, 입력 필드 전체를 disabled 처리했습니다.
  • 사용자를 위한 안내 문구(현재 준비 중인 기능입니다. 조금만 기다려 주세요!)를 추가했습니다.
  • 안내 문구 하단 여백(margin)을 조정해 간격을 자연스럽게 정리했습니다.

🫡 참고사항

백엔드 테스트 서버에서는 기능이 완료된 상태이며 메인 서버 배포 이후 해당 기능은 다시 활성화될 예정입니다.
현재 비활성화는 일시적인 조치입니다.

Summary by CodeRabbit

  • 스타일
    • "동아리 SNS 링크" 제목의 하단 여백이 줄어들었습니다.
    • 동아리 정보 박스 높이가 일시적으로 축소되었습니다.
  • 기능 변경
    • 동아리 SNS 링크 관련 입력란 및 아이콘이 화면에서 제거되었습니다.

@oesnuj oesnuj requested review from Copilot and seongwon030 May 18, 2025 12:35
@oesnuj oesnuj self-assigned this May 18, 2025
@oesnuj oesnuj added 💻 FE Frontend 🛠Fix 기능이 의도한 대로 동작하지 않는 버그를 수정 labels May 18, 2025
@netlify
Copy link

netlify bot commented May 18, 2025

Deploy Preview for moadong ready!

Name Link
🔨 Latest commit 824f788
🔍 Latest deploy log https://app.netlify.com/projects/moadong/deploys/6829f0d704e57400086a8603
😎 Deploy Preview https://deploy-preview-428--moadong.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 40
Accessibility: 69
Best Practices: 92
SEO: 100
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented May 18, 2025

"""

Walkthrough

SNS 링크 입력 기능이 임시로 비활성화되었습니다. 입력 필드가 모두 disabled 처리되었으며, "현재 준비 중인 기능입니다. 조금만 기다려 주세요!"라는 안내 문구가 추가되었습니다. 또한, InfoTitle 스타일의 하단 마진이 46px에서 30px로 조정되었고, InfoBox 컴포넌트의 높이도 197px에서 164px로 임시로 축소되었습니다. ClubDetailPage의 SNS 링크 아이콘 렌더링도 주석 처리되었습니다.

Changes

파일/경로 변경 요약
frontend/src/pages/AdminPage/tabs/ClubInfoEditTab/ClubInfoEditTab.tsx SNS 링크 입력 섹션 전체 주석 처리 및 입력 필드 disabled 처리, 안내 문구 추가 (주석 내)
frontend/src/pages/AdminPage/tabs/ClubInfoEditTab/ClubInfoEditTab.styles.ts InfoTitle 하단 마진 46px → 30px로 수정
frontend/src/pages/ClubDetailPage/components/InfoBox/InfoBox.tsx SnsLinkIcons 임포트 및 사용 주석 처리, SNS 링크 아이콘 렌더링 제거
frontend/src/pages/ClubDetailPage/components/InfoBox/InfoBox.styles.ts InfoBox 높이 197px → 164px로 임시 축소, 나중에 원복 예정 주석 추가

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant ClubInfoEditTab

    User->>ClubInfoEditTab: 페이지 접근
    ClubInfoEditTab->>User: SNS 링크 입력 필드(disabled) 렌더링 (주석처리 상태)
    ClubInfoEditTab->>User: "준비 중입니다" 안내 문구 표시 (주석처리 상태)
Loading

Assessment against linked issues

Objective Addressed Explanation
SNS 입력 필드 임시 비활성화 처리 (disabled or 조건부 렌더링), "준비 중입니다" 안내 문구 추가 (FE-119)

Possibly related issues

Possibly related PRs

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.


Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 82e8266 and 824f788.

📒 Files selected for processing (3)
  • frontend/src/pages/AdminPage/tabs/ClubInfoEditTab/ClubInfoEditTab.tsx (1 hunks)
  • frontend/src/pages/ClubDetailPage/components/InfoBox/InfoBox.styles.ts (1 hunks)
  • frontend/src/pages/ClubDetailPage/components/InfoBox/InfoBox.tsx (2 hunks)
✅ Files skipped from review due to trivial changes (2)
  • frontend/src/pages/ClubDetailPage/components/InfoBox/InfoBox.styles.ts
  • frontend/src/pages/ClubDetailPage/components/InfoBox/InfoBox.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • frontend/src/pages/AdminPage/tabs/ClubInfoEditTab/ClubInfoEditTab.tsx
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR temporarily deactivates the SNS link input functionality and improves the UI layout in the ClubInfoEditTab page.

  • Temporarily disables SNS link inputs using the disabled attribute.
  • Adds a temporary notification message for users about the upcoming feature.
  • Adjusts the bottom margin of the info title for improved spacing.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
frontend/src/pages/AdminPage/tabs/ClubInfoEditTab/ClubInfoEditTab.tsx Temporarily disables SNS inputs and adds a notice message.
frontend/src/pages/AdminPage/tabs/ClubInfoEditTab/ClubInfoEditTab.styles.ts Reduces bottom margin for visual alignment.

</Styled.TagEditGroup>

<Styled.InfoTitle>동아리 SNS 링크</Styled.InfoTitle>
<p>현재 준비 중인 기능입니다. 조금만 기다려 주세요!</p>
Copy link

Copilot AI May 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider using a styled component or adding a CSS class for the temporary notification message to maintain visual consistency with the rest of the page.

Copilot uses AI. Check for mistakes.
Copy link
Member

@seongwon030 seongwon030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니닷

@oesnuj oesnuj merged commit ca0124e into develop-fe May 18, 2025
5 checks passed
@coderabbitai coderabbitai bot mentioned this pull request May 18, 2025
@oesnuj oesnuj deleted the fix/#427-disable-sns-input-before-release-FE-119 branch May 21, 2025 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💻 FE Frontend 🛠Fix 기능이 의도한 대로 동작하지 않는 버그를 수정

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants