Merged
Conversation
- 지원서 제출 후 리다이렉트 시 replace: true 적용 - 뒤로가기 시 이전 페이지로 돌아가서 alert가 반복되는 문제 해결
- ClubApplyButton에서 navigate에 replace: true 추가 - 뒤로가기 시 지원모집 마감 alert 반복 노출 방지
This reverts commit 0aa3b9b.
…it-MOA-116 [feature] 지원서 제출 후 메시지 개선 및 리다이렉트 처리 추가
…nt-MOA-118 [fix] 질문 번호 글꼴 크기 조정으로 정렬 불일치 해결
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
Warning
|
✅ Deploy Preview for moadong ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
frontend/src/components/application/QuestionTitle/QuestionTitle.styles.ts(2 hunks)frontend/src/pages/ApplicationFormPage/ApplicationFormPage.tsx(1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
frontend/**/*.{ts,tsx}
📄 CodeRabbit Inference Engine (frontend/.cursorrules)
frontend/**/*.{ts,tsx}: Replace magic numbers with named constants for clarity.
Replace complex or nested ternary operators with if/else statements or IIFEs for readability.
Assign complex boolean conditions to named variables.
Use consistent return types for similar functions and hooks.
Avoid hidden side effects; functions should only perform actions implied by their signature (Single Responsibility Principle).
Use unique, descriptive names for custom wrappers and functions to avoid ambiguity.
Define constants near related logic or ensure names link them clearly.
Files:
frontend/src/components/application/QuestionTitle/QuestionTitle.styles.tsfrontend/src/pages/ApplicationFormPage/ApplicationFormPage.tsx
frontend/**/*.tsx
📄 CodeRabbit Inference Engine (frontend/.cursorrules)
frontend/**/*.tsx: Abstract complex logic/interactions into dedicated components or higher-order components (HOCs).
Separate significantly different conditional UI/logic into distinct components.
Colocate simple, localized logic or use inline definitions to reduce context switching.
Choose field-level or form-level cohesion based on form requirements.
Break down broad state management into smaller, focused hooks or contexts.
Use component composition instead of props drilling.
Files:
frontend/src/pages/ApplicationFormPage/ApplicationFormPage.tsx
🧠 Learnings (3)
📓 Common learnings
Learnt from: seongwon030
PR: Moadong/moadong#195
File: frontend/src/pages/AdminPage/AdminPage.tsx:7-7
Timestamp: 2025-03-19T05:18:07.818Z
Learning: AdminPage.tsx에서 현재 하드코딩된 클럽 ID('67d2e3b9b15c136c6acbf20b')는 로그인 기능 구현 후 동적으로 가져오는 방식으로 수정될 예정입니다.
frontend/src/components/application/QuestionTitle/QuestionTitle.styles.ts (1)
Learnt from: CR
PR: Moadong/moadong#0
File: frontend/.cursorrules:0-0
Timestamp: 2025-07-19T05:09:10.702Z
Learning: Applies to frontend/**/*.{ts,tsx} : Replace magic numbers with named constants for clarity.
frontend/src/pages/ApplicationFormPage/ApplicationFormPage.tsx (2)
Learnt from: seongwon030
PR: #195
File: frontend/src/pages/AdminPage/AdminPage.tsx:7-7
Timestamp: 2025-03-19T05:18:07.818Z
Learning: AdminPage.tsx에서 현재 하드코딩된 클럽 ID('67d2e3b9b15c136c6acbf20b')는 로그인 기능 구현 후 동적으로 가져오는 방식으로 수정될 예정입니다.
Learnt from: CR
PR: Moadong/moadong#0
File: frontend/.cursorrules:0-0
Timestamp: 2025-07-19T05:09:10.702Z
Learning: Applies to frontend/**/*.{ts,tsx} : Replace magic numbers with named constants for clarity.
🔇 Additional comments (2)
frontend/src/pages/ApplicationFormPage/ApplicationFormPage.tsx (2)
93-96: 성공적인 UX 개선사항입니다.지원서 제출 성공 시 클럽 이름을 포함한 개인화된 메시지와 함께 클럽 상세 페이지로 리디렉션하는 로직이 잘 구현되었습니다.
replace: true옵션을 사용하여 사용자가 뒤로가기로 폼 페이지로 돌아가는 것을 방지한 점도 좋습니다.
98-100: 에러 메시지 개선이 잘 되었습니다.실패 시 경고 이모지와 함께 구체적인 해결 방안을 제시하는 메시지로 개선되어 사용자 경험이 향상되었습니다.
| export const QuestionTitleId = styled.p` | ||
| color: #ff5414; | ||
| font-size: 1.125rem; | ||
| font-size: 1.25rem; |
Contributor
There was a problem hiding this comment.
🛠️ Refactor suggestion
폰트 크기 매직 넘버를 상수로 추출하세요.
코딩 가이드라인에 따라 매직 넘버를 명명된 상수로 교체해야 합니다. 현재 파일에서 1.25rem, 1.05rem 등의 폰트 크기 값이 여러 곳에서 반복 사용되고 있습니다.
다음과 같이 상수를 정의하여 사용하는 것을 권장합니다:
+const FONT_SIZES = {
+ QUESTION_TITLE_DESKTOP: '1.25rem',
+ QUESTION_TITLE_MOBILE: '1.05rem',
+} as const;
export const QuestionTitleId = styled.p`
color: #ff5414;
- font-size: 1.25rem;
+ font-size: ${FONT_SIZES.QUESTION_TITLE_DESKTOP};
font-weight: 700;
margin: 0;
line-height: 1.5;
${media.mobile} {
- font-size: 1.05rem;
+ font-size: ${FONT_SIZES.QUESTION_TITLE_MOBILE};
line-height: 1.4;
}
`;📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| font-size: 1.25rem; | |
| const FONT_SIZES = { | |
| QUESTION_TITLE_DESKTOP: '1.25rem', | |
| QUESTION_TITLE_MOBILE: '1.05rem', | |
| } as const; | |
| export const QuestionTitleId = styled.p` | |
| color: #ff5414; | |
| font-size: ${FONT_SIZES.QUESTION_TITLE_DESKTOP}; | |
| font-weight: 700; | |
| margin: 0; | |
| line-height: 1.5; | |
| ${media.mobile} { | |
| font-size: ${FONT_SIZES.QUESTION_TITLE_MOBILE}; | |
| line-height: 1.4; | |
| } | |
| `; |
🤖 Prompt for AI Agents
In frontend/src/components/application/QuestionTitle/QuestionTitle.styles.ts at
line 17, the font-size value 1.25rem is a magic number and should be replaced
with a named constant. Define a constant at the top of the file for this font
size (e.g., FONT_SIZE_LARGE = '1.25rem') and replace all occurrences of 1.25rem
and similar repeated font sizes like 1.05rem with their respective constants to
improve code readability and maintainability.
…ton-image-MOA-120 [feature] 공유버튼을 카카오톡 이미지로 변경한다
feat: vercel.json 파일 추가 및 리라이트 설정 구성
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용
중점적으로 리뷰받고 싶은 부분(선택)
논의하고 싶은 부분(선택)
🫡 참고사항
Summary by CodeRabbit
Style
New Features
Bug Fixes