[feature] applicationForm delete 구현#854
Merged
alsdddk merged 2 commits intodevelop/befrom Nov 20, 2025
Merged
Conversation
alsdddk
requested review from
PororoAndFriends,
Zepelown,
lepitaaar and
yw6938
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Warning
|
| 코호트 / 파일(s) | 변경 요약 |
|---|---|
컨트롤러 계층backend/src/main/java/moadong/club/controller/ClubApplyAdminController.java |
DELETE /api/club/application/{applicationFormId} 엔드포인트 추가. 인증된 사용자 정보 수신 후 서비스로 위임하고 성공 메시지 반환 |
서비스 계층backend/src/main/java/moadong/club/service/ClubApplyAdminService.java |
public void deleteClubApplicationForm(String applicationFormId, CustomUserDetails user) 메서드 추가 (@Transactional). clubId와 formId로 양식 조회, 미존재 시 APPLICATION_NOT_FOUND 발생, 관련 지원자 삭제 후 양식 삭제 |
저장소 계층backend/src/main/java/moadong/club/repository/ClubApplicantsRepository.java |
파생 쿼리 메서드 void deleteAllByFormId(String formId) 추가 — 지정된 formId의 모든 ClubApplicant 레코드 삭제 |
Sequence Diagram(s)
sequenceDiagram
participant Client
participant Controller as ClubApplyAdminController
participant Service as ClubApplyAdminService
participant FormRepo as ClubApplicationFormRepository
participant ApplicantRepo as ClubApplicantsRepository
Client->>Controller: DELETE /api/club/application/{applicationFormId}
Controller->>Service: deleteClubApplicationForm(applicationFormId, user)
Service->>FormRepo: findByClubIdAndId(clubId, formId)
alt Form Not Found
FormRepo-->>Service: empty
Service-->>Controller: throw APPLICATION_NOT_FOUND
Controller-->>Client: 404 응답
else Form Found
FormRepo-->>Service: ClubApplicationForm
Service->>ApplicantRepo: deleteAllByFormId(formId)
ApplicantRepo-->>Service: delete 완료
Service->>FormRepo: delete(form)
FormRepo-->>Service: delete 완료
Service-->>Controller: void
Controller-->>Client: 200 성공 메시지
end
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~20 minutes
- 추가로 검토할 항목:
@Transactional범위와 데이터 일관성(삭제 순서 및 롤백 행동)- 권한/소유권 검증 로직(요청한 user의 clubId와 양식의 clubId 매칭)
- Repository 파생 쿼리의 정확성 및 인덱스 영향
Possibly related issues
- [feature] MOA-356 지원서 양식을 삭제 할 수 있다 #852 — 동일한 지원서 양식 삭제 기능을 구현하는 변경으로 직접 관련.
Possibly related PRs
- [refactor] 클럽 지원 양식 불러오기 구버전 api를 제거한다 #793 — 동일 서비스 클래스(ClubApplyAdminService)에 대한 변경이 있어 코드 수준 연관성 존재.
- Revert "Revert "[feature] 동아리 지원서 폼 제작 시에 학기를 선택할 수 있고 생성된 모든 지원서 폼을 … #762 — ClubApplicationForm/ClubApplicant 엔티티 및 저장소 관련 수정이 있어 연관 가능.
Suggested reviewers
- Zepelown
- lepitaaar
- PororoAndFriends
- yw6938
Pre-merge checks and finishing touches
❌ Failed checks (1 warning)
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage | Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. | You can run @coderabbitai generate docstrings to improve docstring coverage. |
✅ Passed checks (4 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | ✅ Passed | PR 제목이 변경 사항의 주요 목적을 명확하게 설명합니다. '[feature] applicationForm delete 구현'은 지원서 양식 삭제 기능 구현이라는 핵심 변경 사항을 정확히 전달합니다. |
| Linked Issues check | ✅ Passed | PR의 코드 변경 사항이 연결된 이슈 MOA-356의 요구사항과 일치합니다. 지원서 양식 삭제 API 구현이 성공적으로 완료되었으며, 모든 필요한 계층(Controller, Service, Repository)에서 적절한 로직이 구현되었습니다. |
| Out of Scope Changes check | ✅ Passed | 모든 변경 사항이 연결된 이슈 MOA-356의 범위 내에 있습니다. 추가된 세 개의 메서드는 모두 지원서 양식 삭제 기능 구현이라는 단일 목표에 직접 관련되어 있습니다. |
✨ Finishing touches
- 📝 Generate docstrings
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Post copyable unit tests in a comment
- Commit unit tests in branch
feature/#852-applicationForm-delete-MOA-356
📜 Recent review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
backend/src/main/java/moadong/club/service/ClubApplyAdminService.java(2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- backend/src/main/java/moadong/club/service/ClubApplyAdminService.java
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
Test Results78 tests 75 ✅ 15s ⏱️ Results for commit 64d2233. ♻️ This comment has been updated with latest results. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
backend/src/main/java/moadong/club/service/ClubApplyAdminService.java (1)
127-128: SSE 연결 정리를 고려해보세요.양식 삭제 시 해당 양식과 연관된 SSE 연결(
sseConnections맵)을 명시적으로 정리하는 것이 좋습니다. 현재는 타임아웃(5분)에 의존하고 있지만, 양식이 삭제된 후 즉시 연결을 종료하면 리소스를 더 효율적으로 관리할 수 있습니다.다음과 같이 SSE 연결 정리 로직을 추가할 수 있습니다:
@Transactional public void deleteClubApplicationForm(String applicationFormId, CustomUserDetails user) { ClubApplicationForm applicationForm = clubApplicationFormsRepository.findByClubIdAndId(user.getClubId(), applicationFormId) .orElseThrow(() -> new RestApiException(ErrorCode.APPLICATION_NOT_FOUND)); clubApplicantsRepository.deleteAllByFormId(applicationForm.getId()); clubApplicationFormsRepository.delete(applicationForm); + + // SSE 연결 정리 + String connectionKeyPrefix = user.getClubId() + "_" + applicationFormId + "_"; + sseConnections.entrySet().removeIf(entry -> { + if (entry.getKey().startsWith(connectionKeyPrefix)) { + try { + entry.getValue().complete(); + } catch (Exception ignored) {} + return true; + } + return false; + }); }backend/src/main/java/moadong/club/controller/ClubApplyAdminController.java (1)
72-80: 엔드포인트가 올바르게 구현되었습니다.DELETE 엔드포인트가 인증 및 서비스 계층 위임과 함께 적절하게 구현되었습니다. 다음 선택적 개선 사항을 고려해보세요:
API 문서 개선: Operation description에 "양식 삭제 시 관련된 모든 지원자 정보도 함께 삭제됩니다"와 같이 캐스케이드 삭제 동작을 명시하면 API 사용자에게 더 명확합니다.
입력 검증:
applicationFormId에 대한 기본적인 검증(예:@NotBlank)을 추가하여 빈 값 요청을 사전에 방지할 수 있습니다.선택적으로 다음과 같이 개선할 수 있습니다:
@DeleteMapping("/application/{applicationFormId}") -@Operation(summary = "클럽 지원서 양식 삭제", description = "클럽의 지원서 양식을 삭제합니다") +@Operation(summary = "클럽 지원서 양식 삭제", + description = "클럽의 지원서 양식을 삭제합니다. 양식 삭제 시 관련된 모든 지원자 정보도 함께 삭제됩니다.") @PreAuthorize("isAuthenticated()") @SecurityRequirement(name = "BearerAuth") -public ResponseEntity<?> deleteClubApplicationForm(@PathVariable String applicationFormId, +public ResponseEntity<?> deleteClubApplicationForm(@PathVariable @NotBlank String applicationFormId, @CurrentUser CustomUserDetails user) { clubApplyAdminService.deleteClubApplicationForm(applicationFormId, user); return Response.ok("success delete application"); }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (3)
backend/src/main/java/moadong/club/controller/ClubApplyAdminController.java(1 hunks)backend/src/main/java/moadong/club/repository/ClubApplicantsRepository.java(1 hunks)backend/src/main/java/moadong/club/service/ClubApplyAdminService.java(1 hunks)
🧰 Additional context used
🧠 Learnings (3)
📚 Learning: 2025-09-30T05:26:41.788Z
Learnt from: alsdddk
Repo: Moadong/moadong PR: 765
File: backend/src/main/java/moadong/club/service/ClubApplyService.java:431-435
Timestamp: 2025-09-30T05:26:41.788Z
Learning: In the Moadong codebase's club application feature (backend/src/main/java/moadong/club/), multiple ClubApplicationForm entities can have ACTIVE status for the same clubId, semesterYear, and semesterTerm simultaneously. There is no uniqueness constraint requiring only one ACTIVE form per semester.
Applied to files:
backend/src/main/java/moadong/club/service/ClubApplyAdminService.javabackend/src/main/java/moadong/club/repository/ClubApplicantsRepository.javabackend/src/main/java/moadong/club/controller/ClubApplyAdminController.java
📚 Learning: 2025-05-19T05:45:52.957Z
Learnt from: lepitaaar
Repo: Moadong/moadong PR: 406
File: backend/src/main/java/moadong/club/service/ClubApplyService.java:34-38
Timestamp: 2025-05-19T05:45:52.957Z
Learning: The code duplication between createClubApplication and editClubApplication methods in ClubApplyService.java is acknowledged but will be addressed in a future refactoring, as per the developer's plan.
Applied to files:
backend/src/main/java/moadong/club/service/ClubApplyAdminService.javabackend/src/main/java/moadong/club/repository/ClubApplicantsRepository.javabackend/src/main/java/moadong/club/controller/ClubApplyAdminController.java
📚 Learning: 2025-08-25T14:43:52.320Z
Learnt from: lepitaaar
Repo: Moadong/moadong PR: 703
File: backend/src/main/java/moadong/club/controller/ClubApplyController.java:84-84
Timestamp: 2025-08-25T14:43:52.320Z
Learning: In the Moadong codebase, questionId and clubId are equivalent identifiers that represent the same entity. The ClubApplicationRepository.findAllByIdInAndQuestionId method correctly uses clubId as the questionId parameter for filtering club applications.
Applied to files:
backend/src/main/java/moadong/club/service/ClubApplyAdminService.javabackend/src/main/java/moadong/club/repository/ClubApplicantsRepository.javabackend/src/main/java/moadong/club/controller/ClubApplyAdminController.java
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: test
🔇 Additional comments (1)
backend/src/main/java/moadong/club/repository/ClubApplicantsRepository.java (1)
14-14: LGTM! 파생 쿼리 메서드가 올바르게 추가되었습니다.Spring Data MongoDB의 명명 규칙을 따르는 삭제 메서드가 적절하게 정의되었습니다. 서비스 계층의
@Transactional컨텍스트에서 호출되어 데이터 일관성이 보장됩니다.
yw6938
approved these changes
Nov 19, 2025
Collaborator
|
수고하셨습니당~ |
Zepelown
approved these changes
Nov 19, 2025
Member
Zepelown
left a comment
Zepelown
left a comment
There was a problem hiding this comment.
소프트 삭제가 일단 좋은 점이 많아서 추천드리지만 개인 정보 유지 측면에서는 하드 삭제가 간단하긴 하져
수고하셨습니다.
Merged
This was referenced Jan 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
#852
📝작업 내용
중점적으로 리뷰받고 싶은 부분(선택)
논의하고 싶은 부분(선택)
🫡 참고사항
Summary by CodeRabbit