Skip to content

[feature] 중앙동아리 문구에 학교명 추가#936

Merged
seongwon030 merged 1 commit intodevelop-fefrom
feature/add-school-name
Dec 17, 2025
Merged

[feature] 중앙동아리 문구에 학교명 추가#936
seongwon030 merged 1 commit intodevelop-fefrom
feature/add-school-name

Conversation

@seongwon030
Copy link
Member

@seongwon030 seongwon030 commented Dec 16, 2025

#️⃣연관된 이슈

ex) #이슈번호, #이슈번호

📝작업 내용

#932 핫픽스 PR 반영

중점적으로 리뷰받고 싶은 부분(선택)

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

ex) 메서드 XXX의 이름을 더 잘 짓고 싶은데 혹시 좋은 명칭이 있을까요?

논의하고 싶은 부분(선택)

논의하고 싶은 부분이 있다면 작성해주세요.

🫡 참고사항

Summary by CodeRabbit

  • Style
    • 탭 레이블을 더욱 구체적으로 표시하도록 업데이트했습니다.

✏️ Tip: You can customize this high-level summary in your review settings.

@vercel
Copy link

vercel bot commented Dec 16, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
moadong Ready Ready Preview, Comment Dec 16, 2025 1:35pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 16, 2025

Warning

.coderabbit.yaml has a parsing error

The CodeRabbit configuration file in this repository has a parsing error and default settings were used instead. Please fix the error(s) in the configuration file. You can initialize chat with CodeRabbit to get help with the configuration file.

💥 Parsing errors (1)
Validation error: Invalid regex pattern for base branch. Received: "**" at "reviews.auto_review.base_branches[0]"
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Walkthrough

MainPage 컴포넌트의 탭 레이블을 "중앙동아리"에서 "부경대학교 중앙동아리"로 변경하고, 초기 활성 탭 값을 업데이트하여 일관성을 유지합니다. 데이터 요청이나 주변 로직은 변경되지 않습니다.

Changes

Cohort / File(s) Summary
탭 레이블 업데이트
frontend/src/pages/MainPage/MainPage.tsx
탭 레이블 텍스트를 "중앙동아리"에서 "부경대학교 중앙동아리"로 변경하고, 초기 활성 탭 값을 새 레이블과 일치하도록 조정

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 분

Possibly related issues

  • Moadong/moadong#933: 동일한 MainPage의 "중앙동아리" 레이블을 학교명을 포함하여 업데이트하는 변경사항
  • Moadong/moadong#934: 동일한 MainPage UI 텍스트와 초기 활성 탭 값을 학교명 포함하도록 수정하는 변경사항
  • [hotfix] MOA-425 메인페이지 중앙동아리 문구에 학교명을 추가한다 #931: 동일한 MainPage.tsx의 탭 레이블과 초기 활성 값을 학교명 포함하여 변경하는 작업

Possibly related PRs

Suggested labels

💻 FE

Suggested reviewers

  • lepitaaar
  • Zepelown
  • seongje973

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed PR 제목이 변경사항의 주요 내용과 일치합니다. 중앙동아리 문구에 학교명(부경대학교)을 추가한 것이 정확하게 반영되어 있습니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/add-school-name

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
frontend/src/pages/MainPage/MainPage.tsx (1)

25-26: 변경사항이 올바르게 구현되었습니다.

탭 레이블과 초기 상태가 일관되게 업데이트되어 타입 안전성이 유지되고 있습니다.


선택적 개선: 학교명을 상수로 추출

현재 "부경대학교"가 하드코딩되어 있습니다. 향후 유지보수성을 위해 상수로 추출하는 것을 고려해보세요. 특히 27-28번 라인의 TODO 주석에서 언급된 리팩터링 시 함께 개선하면 좋을 것 같습니다.

코딩 가이드라인에 따라 다음과 같이 개선할 수 있습니다:

+const SCHOOL_NAME = '부경대학교';
+const CENTRAL_CLUB_TAB = `${SCHOOL_NAME} 중앙동아리` as const;
+
 const MainPage = () => {
   useTrackPageView(PAGE_VIEW.MAIN_PAGE);
 
   // ... 기존 코드 ...
   
-  const tabs = ['부경대학교 중앙동아리'] as const;
-  const [active, setActive] = useState<(typeof tabs)[number]>('부경대학교 중앙동아리');
+  const tabs = [CENTRAL_CLUB_TAB] as const;
+  const [active, setActive] = useState<(typeof tabs)[number]>(CENTRAL_CLUB_TAB);
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 3dcf13d and f5203b0.

📒 Files selected for processing (1)
  • frontend/src/pages/MainPage/MainPage.tsx (1 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
frontend/**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (frontend/.cursorrules)

frontend/**/*.{ts,tsx,js,jsx}: Replace magic numbers with named constants for clarity
Replace complex/nested ternaries with if/else or IIFEs for readability
Assign complex boolean conditions to named variables for explicit meaning
Avoid hidden side effects; functions should only perform actions implied by their signature (Single Responsibility Principle)
Use unique and descriptive names for custom wrappers/functions to avoid ambiguity
Define constants near related logic or ensure names link them clearly to avoid silent failures
Break down broad state management into smaller, focused hooks/contexts to reduce coupling

Files:

  • frontend/src/pages/MainPage/MainPage.tsx
frontend/**/*.{tsx,jsx}

📄 CodeRabbit inference engine (frontend/.cursorrules)

frontend/**/*.{tsx,jsx}: Abstract complex logic/interactions into dedicated components/HOCs
Separate significantly different conditional UI/logic into distinct components
Colocate simple, localized logic or use inline definitions to reduce context switching
Choose field-level or form-level cohesion based on form requirements when using form libraries like react-hook-form
Use Component Composition instead of Props Drilling to reduce coupling

Files:

  • frontend/src/pages/MainPage/MainPage.tsx
frontend/**/*.{ts,tsx}

📄 CodeRabbit inference engine (frontend/.cursorrules)

Use consistent return types for similar functions/hooks

Files:

  • frontend/src/pages/MainPage/MainPage.tsx
🧠 Learnings (2)
📓 Common learnings
Learnt from: seongwon030
Repo: Moadong/moadong PR: 195
File: frontend/src/pages/AdminPage/AdminPage.tsx:7-7
Timestamp: 2025-03-19T05:18:07.818Z
Learning: AdminPage.tsx에서 현재 하드코딩된 클럽 ID('67d2e3b9b15c136c6acbf20b')는 로그인 기능 구현 후 동적으로 가져오는 방식으로 수정될 예정입니다.
📚 Learning: 2025-03-19T05:18:07.818Z
Learnt from: seongwon030
Repo: Moadong/moadong PR: 195
File: frontend/src/pages/AdminPage/AdminPage.tsx:7-7
Timestamp: 2025-03-19T05:18:07.818Z
Learning: AdminPage.tsx에서 현재 하드코딩된 클럽 ID('67d2e3b9b15c136c6acbf20b')는 로그인 기능 구현 후 동적으로 가져오는 방식으로 수정될 예정입니다.

Applied to files:

  • frontend/src/pages/MainPage/MainPage.tsx

Copy link
Contributor

@lepitaaar lepitaaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

핫픽스 반영 좋아요

@seongwon030 seongwon030 merged commit 2978c99 into develop-fe Dec 17, 2025
3 checks passed
@seongwon030 seongwon030 deleted the feature/add-school-name branch December 17, 2025 05:13
@coderabbitai coderabbitai bot mentioned this pull request Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💻 FE Frontend ✨ Feature 기능 개발

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants