MobEffect and Potion

[0f-0b]

Also see #538 and #694.

• PotionTypes → Potions
  • func_185217_a: getRegisteredPotionType → getRegisteredPotion
• PotionType → Potion
  • func_185175_b: registerPotionTypes → registerPotions
  • func_185173_a: registerPotionType → registerPotion
• Potion → MobEffect
  • func_199286_c: (none) → makeTranslatableComponent

Reason

In PotionTypes."<clinit>":

throw new RuntimeException("Accessed Potions before Bootstrap!");

In PotionTypes.getRegisteredPotionType:

throw new IllegalStateException("Invalid Potion requested: " + p_getRegisteredPotionType_0_);

In MobEffects.getRegisteredMobEffect:

throw new IllegalStateException("Invalid MobEffect requested: " + p_getRegisteredMobEffect_0_);

[Shadows-of-Fire]

I don't think this is a good idea. MCP names don't rely as heavily on Mob as mojang names, so it would be very inconsistent to push for the use of MobEffect here. If anything, MobEffects should change to Potions and the rest should be left alone.

[pau101]

@Shadows-of-Fire It is true we don't have Mob as apart of entity hierarchy as it actually is, but developers knows what mobs are in the context of the game, and there are many locations where we do actually reference "mob" in code.

Potions, as named currently is wildly inaccurate. Our PotionTypes are the actual potions and the Potion we have is not about potions, but instead merely the representation of an effect applied to mobs, and only some are for potions, others are applied by other game mechanics. These class renames are certainly warranted.

[kashike]

Issues regarding class and package names are now handled in the MCPConfig repository.