Lua Modifier Properties not correctly linked

[SinZ163]

• MODIFIER_PROPERTY_SPELL_AMPLIFY_PERCENTAGE
  Currently the only work around is via messing with everything via Damage Filters, but it would be preferable if this modifier property worked as intended.
  This would make Allow modifying what heroes get per attribute point #16 fully redundant as everything associated to stats will be changeable (with the possible exception of base armour)

  • Doesn't exist in DD (Citation Needed)

• MODIFIER_PROPERTY_CAST_RANGE_BONUS
  Current workarounds include messing with Aether lens (which is simply a hard-coded version of this very property.)

  • Doesn't exist in DD (Citation Needed)

• MODIFIER_PROPERTY_COOLDOWN_PERCENTAGE

  • Works as intended in DD

• MODIFIER_PROPERTY_MANACOST_PERCENTAGE

  • Doesn't exist in DD (Citation Needed)

[DoctorGester]

Probably need a collection of issues/one single big issue, it's not just spell amplify but many other things.

[fcalife]

Adding MODIFIER_PROPERTY_CAST_RANGE_BONUS to the list of broken modifiers. This one doesn't work in DD or lua. Tested @ Nov 24th 2016

--Edit: Added to post - SinZ

[Yahnich]

MODIFIER_PROPERTY_COOLDOWN_PERCENTAGE works in datadriven ~~~but not lua~~~ EDIT: Works fine in Lua - DoctorGester
MODIFIER_PROPERTY_MANACOST_PERCENTAGE is broken in both
--Edit: Added to post - SinZ

[DoctorGester]

Not true, cooldown percentage indeed works in lua for me.

[Wouterz90]

MODIFIER_PROPERTY_SPELL_AMPLIFY_PERCENTAGE can be done by MODIFIER_PROPERTY_TOTALDAMAGEOUTGOING_PERCENTAGE and checking if there was an inflictor. Still would be nice to have this though.

[Yahnich]

MODIFIER_PROPERTY_SPELL_AMPLIFY_PERCENTAGE
MODIFIER_PROPERTY_CAST_RANGE_BONUS
MODIFIER_PROPERTY_CAST_RANGE_BONUS_STACKING
MODIFIER_PROPERTY_HEAL_AMPLIFY_PERCENTAGE
MODIFIER_PROPERTY_MANACOST_PERCENTAGE

are all confirmed fixed for LUA modifiers

[Yunten]

- [x] MODIFIER_PROPERTY_ALWAYS_ALLOW_ATTACK
- [x] MODIFIER_PROPERTY_PREATTACK_TARGET_CRITICALSTRIKE
- [x] MODIFIER_PROPERTY_TEMPEST_DOUBLE
- [ ] MODIFIER_PROPERTY_SUPER_ILLUSION
- [ ] MODIFIER_PROPERTY_SUPER_ILLUSION_WITH_ULTIMATE
- [x] MODIFIER_PROPERTY_MAGICAL_CONSTANT_BLOCK

Not working in LUA