Extract getValidGameShortName method in download manager#2380
Merged
Al12rs merged 1 commit intoModOrganizer2:al/downloadManager-refactorfrom Apr 26, 2026
Conversation
Al12rs
approved these changes
Apr 26, 2026
Al12rs
merged commit 2a8d211
into
ModOrganizer2:al/downloadManager-refactor
3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extracts some duplicated code in the download manager into a
getValidGameShortNamemethod. The order of games is also changed to put thegameShortNameof the currently managed game first in the list, since that's the most likely candidate.Based on #2372 to avoid merge conflicts.