Skip to content

Extended MODL / direct download handling#2384

Merged
Silarn merged 4 commits intomasterfrom
dev/modl-handler
May 3, 2026
Merged

Extended MODL / direct download handling#2384
Silarn merged 4 commits intomasterfrom
dev/modl-handler

Conversation

@Silarn
Copy link
Copy Markdown
Member

@Silarn Silarn commented May 1, 2026

  • name, modname, version, and source options added to download command
  • nxmhandler init adds schemas and MODL entry with default launch args

@Silarn Silarn requested review from Al12rs and Holt59 May 1, 2026 03:56
- name, modname, version, and source options added to download command
- nxmhandler init adds schemas and MODL entry with default launch args
@Silarn Silarn force-pushed the dev/modl-handler branch from 3eb3f4a to 88d9148 Compare May 1, 2026 04:50
Comment thread src/downloadmanager.cpp
Comment thread src/settings.cpp Outdated
@Silarn Silarn force-pushed the dev/modl-handler branch 3 times, most recently from 1e6b936 to cf60281 Compare May 1, 2026 18:59
- Add MODL register button to general tab
- On window display, call meta function to trigger both registrations
@Silarn Silarn force-pushed the dev/modl-handler branch from cf60281 to 1079231 Compare May 1, 2026 19:02
Comment thread src/downloadmanager.cpp Outdated
Comment thread src/settingsdialoggeneral.cpp Outdated
Holt59
Holt59 previously approved these changes May 2, 2026
Copy link
Copy Markdown
Member

@Holt59 Holt59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made minor comments and did not test the change but that looks okay to me.

@Silarn Silarn merged commit ef7499a into master May 3, 2026
4 checks passed
@Silarn Silarn deleted the dev/modl-handler branch May 3, 2026 08:04
@Silarn
Copy link
Copy Markdown
Member Author

Silarn commented May 3, 2026

I guess I might have been slightly premature on this but I think I can do the handler changes tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants