Request projectinfo in bulk #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
That is a lot faster, damn. Thank you for this pull request, I like the progress bar! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requests the projects in bulk instead of one-by-one as described in. #11
The file information is still called once for each project, but the runtime has been cut down from 5-10 minutes to 8 seconds.
I have also included a progressbar in the output, not being able to see the progress is what inspired me to make EnigmaticaModpacks/Enigmatica6#5013 several days ago (never had run your modlist creator myself for that modpack and i had no idea how long it could take without any sort of indicator as to its progress), hence hoping it makes it into the original:
ps, as is evident by this pull request my java skills are not that advanced, so there is probably room for some cleanup. ^-^