Fix #187 by storing univariate_id as int64#198
Merged
skejserjensen merged 4 commits intomainfrom Aug 10, 2024
Merged
Conversation
chrthomsen
reviewed
Aug 9, 2024
chrthomsen
approved these changes
Aug 9, 2024
CGodiksen
requested changes
Aug 9, 2024
CGodiksen
approved these changes
Aug 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #187 by storing
univariate_idasInt64Arrayinstead ofUInt64Arrayas the Delta Lake Protocol does not support unsigned integers and #197 probably will not be resolved for some time. When reviewing this PR, please double check the necessary casts are performed everywhere they are needed. Currently,UInt64Arrayis reinterpreted asInt64Arraywhen writing compressed segments to disk andInt64Arrayis reinterpreted asUInt64Arraywhen data points are reconstructed from segments and aggregates are computed directly from the segments.