Skip to content

Refactor datasets & experiment versions#234

Merged
jonc125 merged 11 commits intomasterfrom
232-file-collections-refactor
Jan 17, 2020
Merged

Refactor datasets & experiment versions#234
jonc125 merged 11 commits intomasterfrom
232-file-collections-refactor

Conversation

@jonc125
Copy link
Copy Markdown
Contributor

@jonc125 jonc125 commented Jan 14, 2020

Fixes #232.

@jonc125 jonc125 self-assigned this Jan 14, 2020
@jonc125 jonc125 changed the base branch from master to 203-split-entity-table January 14, 2020 15:34
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 14, 2020

Codecov Report

Merging #234 into 203-split-entity-table will decrease coverage by 0.31%.
The diff coverage is 25%.

Impacted file tree graph

@@                    Coverage Diff                     @@
##           203-split-entity-table     #234      +/-   ##
==========================================================
- Coverage                      95%   94.69%   -0.32%     
==========================================================
  Files                          65       65              
  Lines                        2625     2637      +12     
  Branches                      273      276       +3     
==========================================================
+ Hits                         2494     2497       +3     
- Misses                         95      101       +6     
- Partials                       36       39       +3
Impacted Files Coverage Δ
weblab/entities/models.py 94.76% <ø> (ø) ⬆️
weblab/repocache/populate.py 78.57% <0%> (-21.43%) ⬇️
weblab/repocache/models.py 96.87% <100%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0bb6b8...123001d. Read the comment docs.

@jonc125 jonc125 marked this pull request as ready for review January 15, 2020 15:31
Copy link
Copy Markdown
Contributor

@sroderick-g5sro sroderick-g5sro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have worked through all the code. - everything seems good to me.

Comment thread weblab/experiments/views.py
@jonc125 jonc125 changed the base branch from 203-split-entity-table to master January 17, 2020 17:18
@jonc125 jonc125 merged commit ff00a86 into master Jan 17, 2020
@jonc125 jonc125 deleted the 232-file-collections-refactor branch January 17, 2020 17:19
MauriceHendrix pushed a commit that referenced this pull request Jul 22, 2021
…actor

Refactor datasets & experiment versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extract commonality between datasets and experiments

3 participants