Template testing#260
Merged
jonc125 merged 4 commits into134-fitting-resultfrom Mar 17, 2020
Merged
Conversation
Contributor
Author
|
Hopefully this will make our tests more robust for the future! |
Contributor
|
I think I see what you have done here ... set the defaults to have a space so it will fail if not set to a valid value? - if so happy to pass review. thanks for your help on this one. |
Contributor
Author
|
Exactly, that's the idea. So models & protocols (etc) generated automatically by tests (except for the few tests that set a name specifically) will have a name that won't work in a URL, hopefully making tests fail wherever the deployed site would fail. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sroderick-g5sro I did a little playing while waiting for tests to run. Looks like the templates are rendered, but they don't check that reverse URL lookups actually exist! So you get the following in the HTML:
Instead of the expected:
Not sure how you'd check for that without having to hard-code every instance, but maybe you can find something!