Skip to content

Template testing#260

Merged
jonc125 merged 4 commits into134-fitting-resultfrom
template-testing
Mar 17, 2020
Merged

Template testing#260
jonc125 merged 4 commits into134-fitting-resultfrom
template-testing

Conversation

@jonc125
Copy link
Copy Markdown
Contributor

@jonc125 jonc125 commented Mar 17, 2020

@sroderick-g5sro I did a little playing while waiting for tests to run. Looks like the templates are rendered, but they don't check that reverse URL lookups actually exist! So you get the following in the HTML:

Corresponding model:\n        <a href="/entities/models/1/versions/mymodel1@9eecdce802a30253b89b3701c5f0d6006e7787a5">mymodel1 @ 9eecdce8...</a>

Instead of the expected:

Corresponding model:\n        <a href="/entities/models/1/versions/9eecdce802a30253b89b3701c5f0d6006e7787a5">mymodel1 @ 9eecdce8...</a>

Not sure how you'd check for that without having to hard-code every instance, but maybe you can find something!

@jonc125 jonc125 changed the base branch from master to 134-fitting-result March 17, 2020 10:00
@jonc125 jonc125 requested a review from sroderick-g5sro March 17, 2020 17:10
@jonc125
Copy link
Copy Markdown
Contributor Author

jonc125 commented Mar 17, 2020

Hopefully this will make our tests more robust for the future!

@sroderick-g5sro
Copy link
Copy Markdown
Contributor

I think I see what you have done here ... set the defaults to have a space so it will fail if not set to a valid value? - if so happy to pass review. thanks for your help on this one.

@jonc125
Copy link
Copy Markdown
Contributor Author

jonc125 commented Mar 17, 2020

Exactly, that's the idea. So models & protocols (etc) generated automatically by tests (except for the few tests that set a name specifically) will have a name that won't work in a URL, hopefully making tests fail wherever the deployed site would fail.

@jonc125 jonc125 merged commit 8cb7486 into 134-fitting-result Mar 17, 2020
@jonc125 jonc125 deleted the template-testing branch March 17, 2020 18:41
MauriceHendrix pushed a commit that referenced this pull request Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants