Conversation
helenst
force-pushed
the
276-list-of-fitting-results
branch
from
bd5e9e7 to
5a27060
Compare
helenst
force-pushed
the
276-list-of-fitting-results
branch
from
5a27060 to
fa02254
Compare
helenst
force-pushed
the
276-list-of-fitting-results
branch
from
fe24fec to
aed1056
Compare
jonc125
reviewed
Oct 13, 2020
Closed
jonc125
requested changes
Oct 15, 2020
Contributor
jonc125
left a comment
jonc125
left a comment
There was a problem hiding this comment.
Looking good. I tweaked some aspects of the display; figured it was easier just to make the changes than put them as review comments. There are just a few minor things to finish off I think.
helenst
force-pushed
the
276-list-of-fitting-results
branch
from
957a4e6 to
ef824cb
Compare
jonc125
approved these changes
Oct 16, 2020
Contributor
jonc125
left a comment
jonc125
left a comment
There was a problem hiding this comment.
Just a very minor suggestion!
I was confused at first that the visibility form still wasn't showing for me (hence the extra test added) but killing & restarting my dev server resolved it 🤷♂️
MauriceHendrix
pushed a commit
that referenced
this pull request
Jul 22, 2021
Lists of fitting results
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #276