Rerun experiments enhancement#302
Merged
sroderick-g5sro merged 6 commits intomasterfrom Oct 20, 2020
Merged
Conversation
sroderick-g5sro
commented
Oct 14, 2020
| 'protocol_id': expt.protocol_id, | ||
| 'protocol_version': expt.protocol_version.sha, | ||
| entity.other_type: other_entity, | ||
| other_entity + '_version': other_version.sha, |
Contributor
Author
There was a problem hiding this comment.
This line errors with TypeError: unsupported operand type(s) for +: 'ProtocolEntity' and 'str'. I wonder if the fix is as simple as wrapping other_entity in str()?
Contributor
There was a problem hiding this comment.
Ah, no, I think it should be entity.other_type + '_version' sorry!
sroderick-g5sro
changed the title
jonc125
approved these changes
Oct 16, 2020
Contributor
jonc125
left a comment
jonc125
left a comment
There was a problem hiding this comment.
Looks good! I've suggested a few minor style/documentation tweaks. No need to get a re-review once those are done though.
Co-authored-by: Jonathan Cooper <j.p.cooper@ucl.ac.uk>
Co-authored-by: Jonathan Cooper <j.p.cooper@ucl.ac.uk>
…rerun-experiments
MauriceHendrix
pushed a commit
that referenced
this pull request
Jul 22, 2021
Rerun experiments enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #230