Replaced Model.set_equation(lhs, rhs) with Model.remove_equation(equation)#171
Merged
MichaelClerx merged 4 commits intodevelopfrom Dec 6, 2019
Merged
Replaced Model.set_equation(lhs, rhs) with Model.remove_equation(equation)#171MichaelClerx merged 4 commits intodevelopfrom
MichaelClerx merged 4 commits intodevelopfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #171 +/- ##
===========================================
- Coverage 95.92% 95.89% -0.04%
===========================================
Files 6 6
Lines 883 876 -7
Branches 186 182 -4
===========================================
- Hits 847 840 -7
Misses 19 19
Partials 17 17
Continue to review full report at Codecov.
|
MauriceHendrix
approved these changes
Dec 2, 2019
Contributor
MauriceHendrix
left a comment
There was a problem hiding this comment.
Looks pretty good to me.
jonc125
reviewed
Dec 3, 2019
jonc125
approved these changes
Dec 3, 2019
Contributor
jonc125
left a comment
There was a problem hiding this comment.
Looks fine. I suggested a possible simplification, but nothing dramatic.
27 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #118.
As discussed in #118 I removed
set_equation(lhs, rhs)and instead addedremove_equation(eq)which can be used together withadd_equation(eq)to achieve the same effect.Types of changes
Checklist: