Fitting test (with static input and output)#216
Draft
MichaelClerx wants to merge 3 commits intomasterfrom
Draft
Conversation
6 tasks
MichaelClerx
force-pushed
the
215-fitting
branch
from
65a7b96 to
d57de36
Compare
MichaelClerx
force-pushed
the
215-fitting
branch
2 times, most recently
from
f30f912 to
90d16d5
Compare
jonc125
reviewed
Oct 30, 2020
Contributor
jonc125
left a comment
jonc125
left a comment
There was a problem hiding this comment.
Is test/models/beattie-2017-ikr.csv really a model? Would it be better in test/input?
jonc125
reviewed
Oct 30, 2020
Contributor
jonc125
left a comment
jonc125
left a comment
There was a problem hiding this comment.
The suggested model loading changes look along sensible lines to me. Which would let the spec find parameters between prepare and compile calls. We'll still need to add a hook into the compilation process to ensure that identified parameters are exposed for modification in the generated pyx code.
|
|
||
| Note that this method is called _before_ the model is manipulated by the protocol, and so | ||
|
|
||
| OR IS IT! |
Contributor
There was a problem hiding this comment.
Yeah, I think I'd do it afterwards.
| if result.returncode != 0: | ||
| raise ProtocolError('Failed to generate executable model code; see output above for details') | ||
|
|
||
| # Create an instance of the model |
Contributor
There was a problem hiding this comment.
We could now tidy up this block using https://docs.python.org/3/library/importlib.html#importing-a-source-file-directly
…a reference trace.
Co-authored-by: Jonathan Cooper <j.p.cooper@ucl.ac.uk>
MichaelClerx
force-pushed
the
215-fitting
branch
from
8e2a9f2 to
13a41cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #215