Fix for out of bounds for blocks #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mineLdiver
requested changes
May 15, 2024
Member
mineLdiver
left a comment
mineLdiver
left a comment
There was a problem hiding this comment.
The fix is invalid - the stat is retrieved from the array before invocation of PlayerEntity#increaseStat, see the argument of the mixin method.
Contributor
Author
|
Now it should be fine |
calmilamsy
reviewed
Jun 19, 2024
Member
calmilamsy
left a comment
calmilamsy
left a comment
There was a problem hiding this comment.
If this has been tested, I'm willing to merge.
Contributor
Author
Yes, it was tested on BH server, works fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple PR that fixes Out Of Bounds for block stats. Fix is temporal before proper realisation will be coded. PR is ready for review