Use JarFileSystem When Scanning Mods #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThexXTURBOXx
commented
Feb 20, 2025
station-api-base/src/main/java/net/modificationstation/stationapi/api/util/Namespace.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
My new attempt was to fix this issue by reverting all the changes from this PR and just replacing the following line: with the following: try (val fs = FileSystemUtil.getJarFileSystem(callerPath, false).get()) {Since this should always get the same Edit: |
ThexXTURBOXx
force-pushed
the
develop
branch
from
6a2b310 to
5c1bf5f
Compare
ThexXTURBOXx
changed the title
Contributor
Author
|
Fixed - the resulting |
calmilamsy
changed the title
Member
|
While this might work, |
Member
|
Ah, I missed that part, I'll push some changes when I'm on proper. |
Member
|
I also need to fix up the PR name and body again considering my inaccurate read of the code. |
calmilamsy
changed the title
mineLdiver
added a commit
that referenced
this pull request
Jul 5, 2025
* Switched from HMI to RetroCommands * Removed broken reimplementation of Divisor's old PlayerAPI. (#139) * Removed Indigo renderer (#140) * Updated UnsafeEvents * ContextVariable * ContextVariable#get * Feature/register helper (#146) * Added register helper methods to RegistryEvent * Remove unused BulkConsumer. * Updated all registries to be entry type bound. * Updated all usages of Registry#register to new helper methods where applicable. * Moved bulk registration helpers implementation to Registry interface and redirected event method helpers to that. * Swapped namespace and rawIdGetter placements so they better reflect the original method arguments. * cleanup/java-hacks (#145) * Cleaned up Java hacks related to entrypoints * Removed EnumFactory. * Removed NativeImage Unsafe buffer cleaner invocation. * Replaced fake BlockItem with null, since MixinExtras allows that, unlike vanilla Mixin's Redirect. * Removed UnsafeProvider. * Updated javadoc for EntrypointManager#registerLookup * Fix a NPE in shears override * Fix a NPE in FuelRegistry * Added StationFlatteningBlock#onStateReplaced * Fixed #159 * Change version * Merge pull request #165 from ThexXTURBOXx/develop Don't close filesystems when resolving mod namespaces * Update modmenu * Merge pull request #168 * Yeet * Wait this is wrong * Merge branch 'develop' into namespace-change * Make stapi get angree (#169) * Update BiomeMixin.java (#196) * Add Block Support to CustomTooltipProvider (#187) * Add Block support to CustomTooltipProvider * Add some documentation to the interface * Make Leaves' Log Check Work With Modded Logs and Leaves (#186) * Fix * And comment this out cause it's ugly * Fix (#185) * FUCK (#200) * Why mine (#197) * Potentially make mine scream (#188) * Implement onBonemealUse on Vanilla Crops (#170) * Yeet * Also do sapling, also fix multiplayer * Use the appropriate random --------- Co-authored-by: mineLdiver <aabesedin@mail.ru> * Fixed cal L moment (cascaded test worldgen) * Change version --------- Co-authored-by: Nico Mexis <nico.mexis@kabelmail.de> Co-authored-by: calmilamsy <bumbill00@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am using symlinks to self-built mods on my system. All those broke in alpha.4 due to the new approach of resolving Namespaces.
This approach tries to address this issue by using fabric's JarFileSystem internals.
It is definitely not the cleanest approach, but it tackles all my use cases as well as the standard use case (just throwing mods into the mods/ folder).