feat: split out client account types#237
Open
eoin-betdex wants to merge 5 commits intoMonacoProtocol:developfrom
Open
feat: split out client account types#237eoin-betdex wants to merge 5 commits intoMonacoProtocol:developfrom
eoin-betdex wants to merge 5 commits intoMonacoProtocol:developfrom
Conversation
obi-ewan
previously approved these changes
Oct 4, 2024
pawel-betdex
previously approved these changes
Oct 4, 2024
pawel-betdex
reviewed
Oct 4, 2024
eoin-betdex
dismissed stale reviews from pawel-betdex and obi-ewan
via
c8c71db
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits out the TS types for protocol accounts into a new package with minimal dependencies. Useful for downstream consumers of protocol data, as well as removing some duplication between the client and admin-client packages.
Also added
AccountNamePrimitiveversions of the interfaces, where web3/solana specific types are replaced with JS primitives. BN becomes number or Date, PublicKey becomes string (base58), enums records become string (PascalCase is the intention).