Skip to content

Conversation

@Ozzywap
Copy link

@Ozzywap Ozzywap commented Apr 14, 2023

Distributed section complete. Added a parallel refresher to recap parallel computing section before diving into distributed computing as per the slides.

#7

osmanhaji added 7 commits April 14, 2023 22:12
Copied over refresher on parallelism section and tried to organised content  in a logical manner.
Added subheadings to create visual gaps between sub topics
Expanded on the slides content by including advantages to contrast with the disadvantages. Outlined the differences to shared memory architecture whenever possible to help reinforce the previous chapter's content
My understanding is OpenMPI section explains what it is and message passing is actually using openMPI. Let me know if this is correct or if i have it backwards.
Message passing section goes into detail how to use OpenMPI and gives some examples on this. Like the last commit lmk if i need to swap this section and with OpenMPI
Moved tasks from slides into here. Let me know if i need to make any changes to these to make them more relevant
Outline for chapter 5 including the new parallel refresher which is missing from the summary.
@Ozzywap Ozzywap added this to the Initial Release - v1.0.0 milestone Apr 14, 2023
@Ozzywap Ozzywap linked an issue Apr 14, 2023 that may be closed by this pull request
4 tasks
@Ozzywap Ozzywap changed the base branch from main to dev April 14, 2023 15:26
@Ozzywap Ozzywap added the enhancement New feature or request label Apr 14, 2023
@Ozzywap Ozzywap requested a review from ankitaagosavi April 14, 2023 15:39
osmanhaji added 2 commits April 15, 2023 10:45
For the book to work properly i needed to update summary.md so that the new topics showed up on the outline. Included few small fixes as well. This commit should be apart of the first pr.
Swapped openMPI section with message Passing as it should come first according to my understanding. This is again done in the summar.md file so you can navigate through the book in the right order.
Copy link
Contributor

@oraqlle oraqlle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Some small quality and consistency changes are needed. Try and come up with new challenges and remember to use the challenge repo to add blueprint/template files and lay out the instructions as this will be where they will save there work. With regards to the Message Passing, try and discuss it from a high level first (which you started on in the 'distrub. comp.' section and then go into what OpenMPI is and how to use it.

``` C
int MPI_Init(int * argc, char ** argv);
// initializes the MPI environment.
//Argc argv are the parameters come
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just make sure the C code style is consistent.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I get you to elaborate on what you mean by this?

@@ -1 +1,50 @@
# Challenges

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try and come up with new challenges. The old repo is not going to be used anymore so they're are not relevant.

@oraqlle oraqlle removed a link to an issue Apr 15, 2023
4 tasks
improved stuff based on comments on pr for better quality and consistency. Have not updated challenges yet however.
@Ozzywap Ozzywap requested a review from oraqlle April 16, 2023 05:29
Copy link
Contributor

@oraqlle oraqlle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@oraqlle oraqlle merged commit b05ec49 into dev Apr 16, 2023
@oraqlle oraqlle added the Distributed Computing Chapter Issues related to the Distributed Computing chapter label May 8, 2023
@oraqlle oraqlle deleted the chapter/distributed-computing branch July 28, 2023 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Distributed Computing Chapter Issues related to the Distributed Computing chapter enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants