-
Notifications
You must be signed in to change notification settings - Fork 1
Chapter/distributed computing completed #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Copied over refresher on parallelism section and tried to organised content in a logical manner.
Added subheadings to create visual gaps between sub topics
Expanded on the slides content by including advantages to contrast with the disadvantages. Outlined the differences to shared memory architecture whenever possible to help reinforce the previous chapter's content
My understanding is OpenMPI section explains what it is and message passing is actually using openMPI. Let me know if this is correct or if i have it backwards.
Message passing section goes into detail how to use OpenMPI and gives some examples on this. Like the last commit lmk if i need to swap this section and with OpenMPI
Moved tasks from slides into here. Let me know if i need to make any changes to these to make them more relevant
Outline for chapter 5 including the new parallel refresher which is missing from the summary.
For the book to work properly i needed to update summary.md so that the new topics showed up on the outline. Included few small fixes as well. This commit should be apart of the first pr.
Swapped openMPI section with message Passing as it should come first according to my understanding. This is again done in the summar.md file so you can navigate through the book in the right order.
oraqlle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Some small quality and consistency changes are needed. Try and come up with new challenges and remember to use the challenge repo to add blueprint/template files and lay out the instructions as this will be where they will save there work. With regards to the Message Passing, try and discuss it from a high level first (which you started on in the 'distrub. comp.' section and then go into what OpenMPI is and how to use it.
src/chapter5/message-passing.md
Outdated
| ``` C | ||
| int MPI_Init(int * argc, char ** argv); | ||
| // initializes the MPI environment. | ||
| //Argc argv are the parameters come |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just make sure the C code style is consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I get you to elaborate on what you mean by this?
| @@ -1 +1,50 @@ | |||
| # Challenges | |||
|
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try and come up with new challenges. The old repo is not going to be used anymore so they're are not relevant.
improved stuff based on comments on pr for better quality and consistency. Have not updated challenges yet however.
oraqlle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Distributed section complete. Added a parallel refresher to recap parallel computing section before diving into distributed computing as per the slides.
#7