Get rid of unused code

[lifus]

[thomwiggers]

itervalues isn't python 3 compatible.

Edit: lots of non python 3 compatible constructs are used. No clue why this doesn't break the tests.

[lifus]

Well, 2to3 takes care of that:

mongoengine/setup.py

Line 54 in 79a2d71

extra_opts['use_2to3'] = True

You might verify that it gets translated to iterable = iter(items.values()) as mentioned in https://www.python.org/dev/peps/pep-0469/

[lifus]

Review status: all files reviewed at latest revision, 2 unresolved discussions.

---

mongoengine/dereference.py, line 93 [r1] (raw file):
Alright, should I replace itervalues with values now or there going to be a separate task for this? There are quite a few usages of iteritems across the repo at the moment

---

mongoengine/queryset/queryset.py, line 159 [r2] (raw file):
I would argue that QuerySetNoDeRef is useless since ba48dfb#diff-8e0357331aaa80635a17e55b89ff235f, but I agree that it would be better to raise deprecation warning for a while

---

Comments from the review on Reviewable.io

[wojcikstefan]

I believe most of this has been addressed by #1428 already. Thanks anyway!