fix for issue #904, also includes a test which checks the error case …

[ms5]

fix for issue #904 includes a test with the test case i reported initially.

[lafrech]

+        if PY3:
+            son_gen = son.items()
+        else:
+            son_gen = son.iteritems()

AFAIU, PY3 is dealt with using 2to3 and elsewhere in the code, only PY2's iteritems is used.

I would have done the same here for consistency, but I'm not sure what the best practice is.

There are indeed see a few if PY3 statements in the code, probably where 2to3 couldn't manage.

[ms5]

thats correct.iteritems() is enough. I've removed the py3 code. I've also added two more test, that check the actual translation to and from SON.

[wojcikstefan]

Thanks for this @ms5 and sorry the conversation stalled for so long. Are you still interested in merging this PR? If so, I'll be happy to work with you on it!

[wojcikstefan]

It would be better to add a docstring to the class above describing exactly what this set of tests ensures. Otherwise, we're forcing every dev to look up a (somewhat poorly worded) GitHub ticket in order to learn what this is about.

[wojcikstefan]

No need to have try-except here. Can be replaced with a.validate() # the test passes if this doesn't raise a ValidationError.

[wojcikstefan]

Fixed in #1501