Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions mongoengine/base/document.py
Original file line number Diff line number Diff line change
Expand Up @@ -684,8 +684,13 @@ def _from_son(cls, son, _auto_dereference=True, only_fields=None, created=False)
# class if unavailable
class_name = son.get('_cls', cls._class_name)

# Convert SON to a dict, making sure each key is a string
data = {str(key): value for key, value in son.iteritems()}
# Convert SON to a data dict, making sure each key is a string and
# corresponds to the right db field.
data = {}
for key, value in son.iteritems():
key = str(key)
key = cls._db_field_map.get(key, key)
data[key] = value

# Return correct subclass for document type
if class_name != cls._class_name:
Expand Down
45 changes: 45 additions & 0 deletions tests/fields/fields.py
Original file line number Diff line number Diff line change
Expand Up @@ -1883,6 +1883,51 @@ class Test(Document):
doc = self.db.test.find_one()
self.assertEqual(doc['x']['i'], 2)

def test_double_embedded_db_field(self):
"""Make sure multiple layers of embedded docs resolve db fields
properly and can be initialized using dicts.
"""
class C(EmbeddedDocument):
txt = StringField()

class B(EmbeddedDocument):
c = EmbeddedDocumentField(C, db_field='fc')

class A(Document):
b = EmbeddedDocumentField(B, db_field='fb')

a = A(
b=B(
c=C(txt='hi')
)
)
a.validate()

a = A(b={'c': {'txt': 'hi'}})
a.validate()

def test_double_embedded_db_field_from_son(self):
"""Make sure multiple layers of embedded docs resolve db fields
from SON properly.
"""
class C(EmbeddedDocument):
txt = StringField()

class B(EmbeddedDocument):
c = EmbeddedDocumentField(C, db_field='fc')

class A(Document):
b = EmbeddedDocumentField(B, db_field='fb')

a = A._from_son(SON([
('fb', SON([
('fc', SON([
('txt', 'hi')
]))
]))
]))
self.assertEqual(a.b.c.txt, 'hi')

def test_embedded_document_validation(self):
"""Ensure that invalid embedded documents cannot be assigned to
embedded document fields.
Expand Down