Skip to content

[WIP] [RFC] Correctly handle pymongo error messages with unicode data under Python 2 #2147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Kami wants to merge 1 commit into from
Closed

[WIP] [RFC] Correctly handle pymongo error messages with unicode data under Python 2 #2147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion mongoengine/document.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,8 +431,15 @@ def save(
self.cascade_save(**kwargs)

except pymongo.errors.DuplicateKeyError as err:
# NOTE: This is a workaround for change introduced in https://github.com/mongodb/mongo-python-driver/commit/e7114087c7af87d804aaa6cdc3696a62c5d59d08#diff-83f588285a24ab0d1ee8a57f88312a6a
# which would cause a failure if error message contains unicode data
# encoded as nn ascii string with unicode escape sequiences
if six.PY2:
err_str = str(err).decode('utf-8')
else:
err_str = six.text_type(err)
message = u"Tried to save duplicate unique keys (%s)"
raise NotUniqueError(message % six.text_type(err))
raise NotUniqueError(message % err_str)
except pymongo.errors.OperationFailure as err:
message = "Could not save document (%s)"
if re.match("^E1100[01] duplicate key", six.text_type(err)):
Expand Down