-
Notifications
You must be signed in to change notification settings - Fork 1.2k
pymongo 4.0 support #2614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pymongo 4.0 support #2614
Conversation
…e count_documents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, Thanks a lot for taking the lead on this @terencehonles. It looks great and the fact that you split it in logical commits made the review so much easier 👍
On top of the minor finding, may I ask you to:
-
update the CHANGELOG and document the potential difference in behavior (and/or add reference to the pymongo migration page https://pymongo.readthedocs.io/en/stable/migrate-to-pymongo4.html). It's important to document any breaking change in both scenario: people upgrading just mongoengine, or upgrading both mongoengine+pymongo. If you don't feel like doing this, just let me know and I'll take over
-
plus, feel free to add yourself to the AUTHORS file as well
|
Alright, that looks great. Thanks again for all the work on this @terencehonles, much appreciated! |
This change follows up on top of #2600 and includes the following updates:
GEOHAYSTACKremovalmax_pool_sizemovemap_reduceandinline_map_reduceremovalsevalremovalpythonLegacyUUID encoding for compatability with pymongo 3.x.collection.updatelen(list(queryset))or modify the query as needed).db.authenticateremovalThe test suite is now passing locally and I'm opening this up in the main repo to run against the CI. I had originally opened bagerard#20 to update #2600.
Fixes: #2598