tiny-plot: consistent color assignment across classes, detail improvements in legend and codebase#220
Merged
taimontgomery merged 1 commit intomasterfrom Aug 4, 2022
Merged
Conversation
…s color assignment so that colors are consistent across samples. This method and its signature have been cleaned up a bit. This has helped simplify plotter.scatter_dges() as well tiny-plot will also fail over to a 20 item colormap if the number of groups exceeds the number of colors defined in the user's stylesheet. Categorical color maps over 20 items aren't offered by MPL, but if needed the map will repeat as necessary
Member
Author
|
This PR is ready to be merged but PR #214 needs to be merged first |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvements in
sample_avg_scatter_by_dge*plots:The code in plotterlib.scatter_grouped() has been refined, and the code in plotter.scatter_dge() has been slightly simplified.
Closes #219