CSVReader: ellipsis character replacement, empty rows are skipped#290
Merged
taimontgomery merged 3 commits intomasterfrom Mar 7, 2023
Merged
CSVReader: ellipsis character replacement, empty rows are skipped#290taimontgomery merged 3 commits intomasterfrom
taimontgomery merged 3 commits intomasterfrom
Conversation
…by Microsoft Excel. This isn't a total solution; if the user opens and saves the documents in other editing tools, particularly if they introduce a utf-16-related encoding standard, then this will still fail.
…ly whitespace values
Collaborator
|
Did not test specific issue this PR addresses. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CSVReader now replaces the ellipsis character, which Microsoft Excel autocorrects from three periods, in header lines. The corrected file is written to disk because there isn't a good way to do this on-the-fly.
Rows that are empty/whitespace don't have any useful meaning in our config files, and they cause problems while parsing. These rows are now skipped.
Closes #288