Skip to content

Conversation

@tifasoftware
Copy link

I went into Xcode and found suitable replacements for the dated icons in the user interface.
These icons should make the UI more professional and more fitting for Apple's overall theme.
Screenshot 2024-04-28 at 9 53 53 PM

Updated the Storyboard to have fitting icons supplied by apple
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Moonif
Copy link
Owner

Moonif commented Apr 29, 2024

Thank you for your contribution!

Personally, I prefer the retro icons, as they are more suitable for the purpose of the app and they match the style of 86Box and the systems you run on it.

Let's leave this PR open, because I think I'll add it as an option in the Settings window (ex: Theme selection).

@tifasoftware
Copy link
Author

Making this a user-selected option would be the best compromise. However, I recommend that we make this new theme the default, as it would give a better impression for newcomers. And if those who have been used this software longer can revert back if they don't like the SF glyphs.

@rxhfcy
Copy link

rxhfcy commented May 20, 2024

Making this a user-selected option would be the best compromise. However, I recommend that we make this new theme the default, as it would give a better impression for newcomers. And if those who have been used this software longer can revert back if they don't like the SF glyphs.

Random drive-by comment: argh noooo please don't add preferences for trivial things like this, pick any icons (IMHO the suggested SF Glyphs are super obviously way better in every possible way, but the maintainer gets to dictate stuff like this)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants