fix(web): prevent WebSocket reconnection storm in session stream#1386
Merged
fix(web): prevent WebSocket reconnection storm in session stream#1386
Conversation
…ality Entire-Checkpoint: e0d2f5c69e51
…switches - Add optional chaining on Map.clear() calls in resetState to prevent TypeError during React unmount when refs are already null - Pass preserveSlashCommands=true in useLayoutEffect and clearMessages to avoid clearing available commands during session switches Entire-Checkpoint: 2977bc73228c
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Entire-Checkpoint: 8e8115e3489b
howardpen9
added a commit
to howardpen9/kimi-cli
that referenced
this pull request
Mar 12, 2026
…n storms The `connect` callback had many unstable dependencies (handleMessage, onError, sendInitialize, etc.) that frequently changed identity due to their own deep dependency chains. When connect changed, it cascaded to reconnect → sendMessage → queue auto-send effects, potentially causing rapid connect/close/reconnect cycles. This extends the ref-based pattern from MoonshotAI#1386 to all callbacks used inside connect(). By reading from refs (handleMessageRef, onErrorRef, etc.) instead of capturing callbacks directly, connect() only depends on sessionId and stable state setters, breaking the cascade. Closes MoonshotAI#1409
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Internal discovery — no linked issue.
Description
useSessionStreamhook suffered from a WebSocket reconnection storm caused by unstable callback identity chains:resetStatedepended onslashCommands.lengthin itsuseCallbackdependency arrayinitializeresponse setslashCommands,resetStateidentity changedconnect→useLayoutEffect→ disconnect/reconnect → loopFixes:
resetStateidentity: ReplaceslashCommands.lengthdependency with aslashCommandsLenRefref, and use aresetStateRefto accessresetStatefrom effects without adding it to dependency arrayspreserveSlashCommands=trueinuseLayoutEffectandclearMessagesso available commands are not cleared during the gap before theinitializeresponse arrives?.) onMap.clear()calls insideresetStateto preventTypeError: Cannot read properties of null (reading 'clear')when React nulls out refs during component teardownChecklist
make gen-changelogto update the changelog.make gen-docsto update the user documentation.