feat: Add --out and --patches arguments to list-patches command#60
feat: Add --out and --patches arguments to list-patches command#60prateek-who wants to merge 9 commits intoMorpheApp:devfrom
--out and --patches arguments to list-patches command#60Conversation
Added --out and -- patches flag for list-command.
|
Unrelated to this. But there are multiple issues related to keystore. What are the problems there? |
|
I don't use keystore and have never tried using it. If reproduction steps exist then someone can make an issue for it. |
Added --out and -- patches flag for list-command.
LisoUseInAIKyrios
force-pushed
the
list-patches-out-flag
branch
from
266ad97 to
51ca317
Compare
LisoUseInAIKyrios
force-pushed
the
list-patches-out-flag
branch
from
088c628 to
ec25d1a
Compare
LisoUseInAIKyrios
changed the title
--out and --patches arguments for list-patches command
LisoUseInAIKyrios
changed the title
--out and --patches arguments for list-patches command--out and --patches arguments to list-patches command
|
Will merge tomorrow if there's no new reviews or changes |
…-cli into list-patches-out-flag
| ?: withUniversalPatches | ||
|
|
||
| val patches = loadPatchesFromJar(patchesFiles).withIndex().toList() | ||
| if (patchFiles.isNullOrEmpty()) return logger.warning("No patch file provided. Please specify one or more mpp files using --patches") |
There was a problem hiding this comment.
Instead, add required = true to the option.
PatchCommand.kt is useful as a reference.
There was a problem hiding this comment.
yea, that's better. Will change this.
|
|
||
| @Option( | ||
| names = ["--out"], | ||
| description = ["Path to the output text file."], |
There was a problem hiding this comment.
I think there should be a phrase somewhere that says "instead of stdout."
This makes it clear to someone seeing the usage of this command for the first time that the --out option is optional and that by default it will print to standard output.
My suggestion:
| description = ["Path to the output text file."], | |
| description = ["Path to output the patch list to instead of stdout."], |
This "Path to V O to." sentence is often used in PatchCommand, so I'm sure this is fine
|
@kitadai31 Could you check if it's better now? |
Good! |
3 participants
As the title says, they have been added.
Completely written by me this time, lmaoo. Please be harsh on the review aswell. I seem to be finally learning something and want to continue to do so. Hopefully I am able to do more by myself soon!