Open
Conversation
This commit addresses multiple critical issues found during code audit: MEMORY LEAK FIXES: - Add deinit to MGWebServer to remove NotificationCenter observers - Invalidate URLSession in stop() and deinit to release resources - Remove dangerous Utils.repeatTask() function (unstoppable infinite recursion) - Clear all NetService delegate references in cleanup methods - Add deinit to BonjourServiceManager and BonjourClientManager - Set audioPlayer to nil after stopping in AudioPlaybackManager - Add deinit to AudioPlaybackManager for proper cleanup SAFETY & SECURITY FIXES: - Remove all force unwrapping (!): * MGWebServer.swift: Safe port number handling * HTTPRequest.swift: Safe boundary data encoding * Utils.swift: Safe pointer handling in getIPAddress() - Add path validation to prevent directory traversal attacks in RouteManager - Add validateAndSanitizePath() to ensure files stay within base directory THREAD SAFETY: - Make RouteManager thread-safe with serial DispatchQueue - Add proper synchronization for routes dictionary access CRASH PREVENTION: - Fix recursive receive() in RequestHandler (potential stack overflow) - Dispatch next receive to queue instead of direct recursion - Add request size limits (10 MB max) to prevent memory exhaustion - Add HTTP 413 status code for oversized requests - Proper connection cleanup to prevent resource leaks CODE IMPROVEMENTS: - Add proper [weak self] captures in all closures - Add connection cleanup tracking in RequestHandler - Add status codes 403 and 413 to HTTPResponse - Improve error handling throughout All critical and high-priority issues from the audit have been resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit addresses multiple critical issues found during code audit:
MEMORY LEAK FIXES:
SAFETY & SECURITY FIXES:
THREAD SAFETY:
CRASH PREVENTION:
CODE IMPROVEMENTS:
All critical and high-priority issues from the audit have been resolved.