Fixed the RenderFlex overflow #218

grunch · 2025-07-21T18:30:21Z

Root Cause Fixed:

The Row widget at line 34 in form_section.dart contained a Text widget that couldn't handle text wrapping
Long localized strings (especially Spanish: 73+ characters) caused a 186-pixel overflow

Solution Implemented:

Wrapped title Text in Expanded: Allows the text to take available space and prevents overflow
Added text wrapping properties:

softWrap: true - Enables natural text wrapping
maxLines: null - Allows unlimited lines for proper text flow

Preserved icon positioning: The info icon remains properly positioned next to the text

Summary by CodeRabbit

Improvements
- Enhanced text wrapping and layout in order form sections for better readability.
- Improved arrangement of trade list items, ensuring clearer separation of information and better handling of long text.
Localization
- Removed the English translation for the "DONE" button label.

Root Cause Fixed: - The Row widget at line 34 in form_section.dart contained a Text widget that couldn't handle text wrapping - Long localized strings (especially Spanish: 73+ characters) caused a 186-pixel overflow Solution Implemented: 1. Wrapped title Text in Expanded: Allows the text to take available space and prevents overflow 2. Added text wrapping properties: - softWrap: true - Enables natural text wrapping - maxLines: null - Allows unlimited lines for proper text flow 3. Preserved icon positioning: The info icon remains properly positioned next to the text

coderabbitai · 2025-07-21T18:30:28Z

Walkthrough

The changes adjust UI layouts for two widgets: FormSection now allows its title to wrap onto multiple lines, and TradesListItem reorganizes its rows for clearer display and improved text overflow handling. Additionally, the English localization key for "doneButton" was removed from the resource file.

Changes

File(s)	Change Summary
lib/features/order/widgets/form_section.dart	Wrapped title `Text` in `Expanded`, enabled multi-line wrapping with `softWrap: true` and `maxLines: null`.
lib/features/trades/widgets/trades_list_item.dart	Rearranged layout: moved "Buy/Sell" to first row, consolidated chips in second row, improved text overflow.
lib/l10n/intl_en.arb	Removed the `"doneButton": "DONE"` localization key.

Sequence Diagram(s)

sequenceDiagram
  participant User
  participant FormSectionWidget
  participant TradesListItemWidget

  User->>FormSectionWidget: Render with long title
  FormSectionWidget-->>User: Title wraps onto multiple lines

  User->>TradesListItemWidget: View trade item
  TradesListItemWidget-->>User: "Buy/Sell" on first row
  TradesListItemWidget-->>User: Status, role, premium chips on second row
  TradesListItemWidget-->>User: Fiat amount with ellipsis on third row

Estimated code review effort

2 (~15 minutes)

Possibly related PRs

UI Refinements for My Trades Screen #116: Refactors and simplifies the TradesListItem widget, reorganizing text, chips, and premium display logic—directly related to the current changes in the same widget.
Fix UI improvements in the Create Order screen #109: Adds an infoTooltip property and modifies the title display in FormSection, overlapping with this PR's changes to title wrapping in the same widget.

Suggested reviewers

Catrya

Poem

A title now wraps, no words left behind,
Trades list reshuffled, more clearly aligned.
The "DONE" key is gone, the code feels more neat,
UI bunnies rejoice, for the layout’s complete!
🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 49f109b and cdd4d58.

📒 Files selected for processing (3)

lib/features/order/widgets/form_section.dart (1 hunks)
lib/features/trades/widgets/trades_list_item.dart (2 hunks)
lib/l10n/intl_en.arb (0 hunks)

💤 Files with no reviewable changes (1)

lib/l10n/intl_en.arb

🧰 Additional context used

📓 Path-based instructions (2)

lib/**/*.dart

📄 CodeRabbit Inference Engine (CLAUDE.md)

lib/**/*.dart: Use S.of(context).yourKey for all user-facing strings
Always check mounted before using context after async operations

Files:

lib/features/order/widgets/form_section.dart
lib/features/trades/widgets/trades_list_item.dart

**/*.dart

📄 CodeRabbit Inference Engine (CLAUDE.md)

**/*.dart: Remove unused imports and dependencies
Use const constructors where possible

Files:

lib/features/order/widgets/form_section.dart
lib/features/trades/widgets/trades_list_item.dart

🔇 Additional comments (4)

lib/features/order/widgets/form_section.dart (1)

36-45: LGTM! Excellent solution for the overflow issue.

The implementation correctly addresses the RenderFlex overflow by:

Wrapping the title Text in an Expanded widget to utilize available horizontal space

Adding softWrap: true and maxLines: null for proper text wrapping

Preserving the info icon positioning in the Row layout

This solution effectively handles long localized strings while maintaining the intended UI design.

lib/features/trades/widgets/trades_list_item.dart (3)

56-66: Well-structured first row layout.

The Buy/Sell Bitcoin text now has its own dedicated row with full width, improving layout clarity and reducing potential overflow issues. The localization usage with S.of(context) follows the coding guidelines correctly.

69-97: Improved second row organization with consolidated premium chip logic.

The reorganization successfully:

Groups related elements (status, role, premium) logically

Consolidates premium chip display logic with cleaner conditional rendering

Uses const Spacer() appropriately for layout alignment

Maintains consistent styling and color theming

The premium display logic if (trade.premium != null && trade.premium != '0') is more explicit and handles edge cases better.

100-128: Excellent overflow handling with Flexible widget.

The third row implementation properly addresses text overflow:

Flexible widget allows the amount text to take available space

TextOverflow.ellipsis prevents overflow with graceful truncation

Flag emoji and currency display remain intact

Complex amount range logic is handled correctly

This approach is more robust than the previous layout for handling varying text lengths.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

grunch merged commit 0256e85 into main Jul 21, 2025
2 checks passed

grunch deleted the fix/UI-overflow branch July 21, 2025 18:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fixed the RenderFlex overflow #218

Fixed the RenderFlex overflow #218

Uh oh!

grunch commented Jul 21, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jul 21, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Fixed the RenderFlex overflow #218

Fixed the RenderFlex overflow #218

Uh oh!

Conversation

grunch commented Jul 21, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

grunch commented Jul 21, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 21, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)