Show user's reputation real data on trade details #225

grunch · 2025-07-23T13:14:16Z

Changes Made:

Added Required Imports:

dart_nostr/nostr/model/event/event.dart for NostrEvent
mostro_mobile/data/models/nostr_event.dart for rating extensions

Updated Build Method:

Added final originalOrder = ref.watch(eventProvider(orderId)) to get the original NostrEvent
Updated null check to include originalOrder == null
Modified the call to pass originalOrder to _buildCreatorReputation

Updated _buildCreatorReputation Method:

Changed signature from OrderState tradeState to NostrEvent order
Replaced hardcoded values with real data extraction:
- rating = order.rating?.totalRating ?? 0.0
- reviews = order.rating?.totalReviews ?? 0
- days = order.rating?.days ?? 0

Key Features:

Real Rating Data: Now displays actual user reputation from NostrEvent
Graceful Fallbacks: Uses ?? 0 operators for null safety
Consistent Pattern: Follows same approach as take_order_screen.dart
Zero Analyzer Issues: Code passes flutter analyze with no warnings
Successful Build: Confirmed working with debug build

Summary by CodeRabbit

New Features
- The creator's reputation card now displays dynamic rating and review information sourced from the original order event, providing more accurate and up-to-date details.
Bug Fixes
- Improved loading behavior to ensure all necessary order and event data are available before displaying the screen.

Changes Made: 1. Added Required Imports: - dart_nostr/nostr/model/event/event.dart for NostrEvent - mostro_mobile/data/models/nostr_event.dart for rating extensions 2. Updated Build Method: - Added final originalOrder = ref.watch(eventProvider(orderId)) to get the original NostrEvent - Updated null check to include originalOrder == null - Modified the call to pass originalOrder to _buildCreatorReputation 3. Updated _buildCreatorReputation Method: - Changed signature from OrderState tradeState to NostrEvent order - Replaced hardcoded values with real data extraction: - rating = order.rating?.totalRating ?? 0.0 - reviews = order.rating?.totalReviews ?? 0 - days = order.rating?.days ?? 0 Key Features: - Real Rating Data: Now displays actual user reputation from NostrEvent - Graceful Fallbacks: Uses ?? 0 operators for null safety - Consistent Pattern: Follows same approach as take_order_screen.dart - Zero Analyzer Issues: Code passes flutter analyze with no warnings - Successful Build: Confirmed working with debug build

coderabbitai · 2025-07-23T13:14:23Z

Walkthrough

The TradeDetailScreen widget now integrates the NostrEvent data source by watching an additional provider to retrieve the original order event. The creator's reputation card is updated to use data from NostrEvent instead of static values or the OrderState object. The _buildCreatorReputation method's signature is changed accordingly.

Changes

File(s)	Change Summary
lib/features/trades/screens/trade_detail_screen.dart	Integrated `NostrEvent` as a data source, updated provider usage, revised reputation card logic, and changed `_buildCreatorReputation` method signature.

Sequence Diagram(s)

sequenceDiagram
    participant UI as TradeDetailScreen
    participant Provider1 as orderNotifierProvider
    participant Provider2 as eventProvider(orderId)
    participant NostrEvent
    participant OrderState

    UI->>Provider1: Watch orderNotifierProvider(orderId)
    Provider1-->>UI: Return OrderState (orderPayload)
    UI->>Provider2: Watch eventProvider(orderId)
    Provider2-->>UI: Return NostrEvent (originalOrder)
    UI->>NostrEvent: Extract rating info for reputation card
    UI->>UI: Render screen when both orderPayload and originalOrder are non-null

Estimated code review effort

2 (~15 minutes)

Poem

In the garden of trades, a new source appears,
NostrEvent whispers ratings in digital ears.
Reputation now blooms from a different seed,
As rabbits review, their work’s guaranteed.
A hop, a skip, through code so neat—
This patch makes the detail screen complete! 🥕

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

lib/features/trades/screens/trade_detail_screen.dart (1)

69-71: LGTM! Good temporary solution with clear documentation.

The TODO comment provides excellent context for the temporary use of NostrEvent and the method call correctly passes the new parameter. Consider tracking this TODO as a future enhancement item.

Would you like me to help create a GitHub issue to track the TODO for updating the Order model with rating information?

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f18953b and 1a3de63.

📒 Files selected for processing (1)

lib/features/trades/screens/trade_detail_screen.dart (5 hunks)

📓 Path-based instructions (2)

lib/**/*.dart

📄 CodeRabbit Inference Engine (CLAUDE.md)

lib/**/*.dart: Use S.of(context).yourKey for all user-facing strings
Always check mounted before using context after async operations

Files:

lib/features/trades/screens/trade_detail_screen.dart

**/*.dart

📄 CodeRabbit Inference Engine (CLAUDE.md)

**/*.dart: Remove unused imports and dependencies
Use const constructors where possible

Files:

lib/features/trades/screens/trade_detail_screen.dart

🧠 Learnings (2)

📓 Common learnings

Learnt from: chebizarro
PR: MostroP2P/mobile#74
File: lib/features/trades/models/trade_state.dart:1-15
Timestamp: 2025-05-08T16:06:33.665Z
Learning: In the context of the Mostro Mobile app, the `TradeState` class is specifically constructed using the `tradeStateProvider`. While some fields are nullable (`lastAction` and `orderPayload`), they are still marked as required parameters to ensure they are explicitly considered during state construction.

lib/features/trades/screens/trade_detail_screen.dart (15)

Learnt from: CR
PR: MostroP2P/mobile#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-20T01:48:43.335Z
Learning: Applies to lib/data/models/nostr_event.dart : Custom timeAgoWithLocale() method is implemented in the NostrEvent extension

Learnt from: CR
PR: MostroP2P/mobile#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-20T01:48:43.335Z
Learning: Applies to lib/services/nostr_service.dart : Nostr protocol interactions go through services/nostr_service.dart

Learnt from: chebizarro
PR: #127
File: lib/features/order/notfiers/abstract_mostro_notifier.dart:45-54
Timestamp: 2025-06-26T15:03:23.529Z
Learning: In AbstractMostroNotifier, state updates occur for all messages regardless of timestamp to hydrate the OrderNotifier from MostroStorage during sync, while handleEvent is only called for recent messages (within 60 seconds) to prevent re-triggering side effects like notifications and navigation for previously handled messages. This design prevents displaying stale notifications when the app is reopened or brought to the foreground.

Learnt from: chebizarro
PR: #74
File: lib/features/trades/models/trade_state.dart:1-15
Timestamp: 2025-05-08T16:06:33.665Z
Learning: In the context of the Mostro Mobile app, the TradeState class is specifically constructed using the tradeStateProvider. While some fields are nullable (lastAction and orderPayload), they are still marked as required parameters to ensure they are explicitly considered during state construction.

Learnt from: chebizarro
PR: #74
File: lib/services/mostro_service.dart:70-76
Timestamp: 2025-05-06T15:49:26.443Z
Learning: In the Mostro Mobile codebase, eventStorageProvider is exported from package:mostro_mobile/shared/providers/mostro_service_provider.dart and not from a separate event_storage_provider.dart file.

Learnt from: CR
PR: MostroP2P/mobile#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-20T01:48:43.335Z
Learning: Use Riverpod for all state management

Learnt from: CR
PR: MostroP2P/mobile#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-20T01:48:43.335Z
Learning: Applies to lib/core/app_routes.dart : GoRouter navigation is configured in core/app_routes.dart

Learnt from: chebizarro
PR: #74
File: lib/services/mostro_service.dart:70-76
Timestamp: 2025-05-06T15:49:26.443Z
Learning: In the Mostro Mobile codebase, Riverpod code generation is used with @Riverpod annotations. Providers like eventStorageProvider are generated in .g.dart files from annotated functions in the main provider files. These providers are accessible by importing the main provider file (e.g., mostro_service_provider.dart), not by importing a separate provider file.

Learnt from: CR
PR: MostroP2P/mobile#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-20T01:48:43.335Z
Learning: Applies to test/mocks.mocks.dart : DO NOT modify test/mocks.mocks.dart - it already has file-level ignores

Learnt from: CR
PR: MostroP2P/mobile#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-20T01:48:43.335Z
Learning: Applies to lib/data/models.dart : Models should be exported through data/models.dart

Learnt from: CR
PR: MostroP2P/mobile#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-20T01:48:43.335Z
Learning: Applies to lib/background/**/*.dart : Background services are implemented in the background/ directory

Learnt from: CR
PR: MostroP2P/mobile#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-20T01:48:43.335Z
Learning: Applies to **/*.dart : Remove unused imports and dependencies

Learnt from: CR
PR: MostroP2P/mobile#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-20T01:48:43.335Z
Learning: Applies to lib/core/mostro_fsm.dart : Order state transitions are managed by core/mostro_fsm.dart

Learnt from: CR
PR: MostroP2P/mobile#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-20T01:48:43.335Z
Learning: Applies to lib/features//notifiers/**/.dart : Notifiers for complex state logic are placed in features/{feature}/notifiers/

Learnt from: CR
PR: MostroP2P/mobile#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-20T01:48:43.335Z
Learning: Applies to lib/shared/providers/mostro_database_provider.dart : Database initialization is in shared/providers/mostro_database_provider.dart

🧰 Additional context used

📓 Path-based instructions (2)

lib/**/*.dart

📄 CodeRabbit Inference Engine (CLAUDE.md)

lib/**/*.dart: Use S.of(context).yourKey for all user-facing strings
Always check mounted before using context after async operations

Files:

lib/features/trades/screens/trade_detail_screen.dart

**/*.dart

📄 CodeRabbit Inference Engine (CLAUDE.md)

**/*.dart: Remove unused imports and dependencies
Use const constructors where possible

Files:

lib/features/trades/screens/trade_detail_screen.dart

🧠 Learnings (2)

📓 Common learnings

Learnt from: chebizarro
PR: MostroP2P/mobile#74
File: lib/features/trades/models/trade_state.dart:1-15
Timestamp: 2025-05-08T16:06:33.665Z
Learning: In the context of the Mostro Mobile app, the `TradeState` class is specifically constructed using the `tradeStateProvider`. While some fields are nullable (`lastAction` and `orderPayload`), they are still marked as required parameters to ensure they are explicitly considered during state construction.