-
Notifications
You must be signed in to change notification settings - Fork 16
Improve info button UX and standardize dialog styling #227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Increase touch area for all info (i) icons with 8px padding - Fix line breaks in price type tooltip localization - Standardize payment method dialog buttons to match generate user dialog style - Update Confirm button to green background with black text and rounded borders
WalkthroughThis update standardizes the UI for info icons and dialogs across several screens by adding consistent padding around info icons, updating dialog button styles, and improving localization string formatting for tooltips. It also introduces an optional info dialog title for the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant FormSection
participant Dialog
User->>FormSection: Tap info icon
FormSection->>FormSection: _showInfoDialog(context, infoTitle, infoTooltip)
FormSection->>Dialog: Show AlertDialog with title and content
User->>Dialog: Tap OK
Dialog-->>User: Dialog closes
Estimated code review effort1 (~8 minutes) Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (10)
📓 Path-based instructions (5)lib/**/*.dart📄 CodeRabbit Inference Engine (CLAUDE.md)
Files:
**/*.dart📄 CodeRabbit Inference Engine (CLAUDE.md)
Files:
lib/l10n/intl_{en,es,it}.arb📄 CodeRabbit Inference Engine (CLAUDE.md)
Files:
lib/l10n/*.arb📄 CodeRabbit Inference Engine (CLAUDE.md)
Files:
lib/l10n/**📄 CodeRabbit Inference Engine (CLAUDE.md)
Files:
🧠 Learnings (8)lib/features/settings/about_screen.dart (1)Learnt from: CR lib/features/settings/settings_screen.dart (1)Learnt from: CR lib/l10n/intl_en.arb (2)Learnt from: CR Learnt from: CR lib/l10n/intl_es.arb (2)Learnt from: CR Learnt from: CR lib/features/order/widgets/payment_methods_section.dart (2)Learnt from: CR Learnt from: CR lib/features/key_manager/key_management_screen.dart (3)Learnt from: CR Learnt from: CR Learnt from: chebizarro lib/features/order/widgets/form_section.dart (4)Learnt from: CR Learnt from: CR Learnt from: CR Learnt from: CR lib/l10n/intl_it.arb (2)Learnt from: CR Learnt from: CR 🧰 Additional context used📓 Path-based instructions (5)lib/**/*.dart📄 CodeRabbit Inference Engine (CLAUDE.md)
Files:
**/*.dart📄 CodeRabbit Inference Engine (CLAUDE.md)
Files:
lib/l10n/intl_{en,es,it}.arb📄 CodeRabbit Inference Engine (CLAUDE.md)
Files:
lib/l10n/*.arb📄 CodeRabbit Inference Engine (CLAUDE.md)
Files:
lib/l10n/**📄 CodeRabbit Inference Engine (CLAUDE.md)
Files:
🧠 Learnings (8)lib/features/settings/about_screen.dart (1)Learnt from: CR lib/features/settings/settings_screen.dart (1)Learnt from: CR lib/l10n/intl_en.arb (2)Learnt from: CR Learnt from: CR lib/l10n/intl_es.arb (2)Learnt from: CR Learnt from: CR lib/features/order/widgets/payment_methods_section.dart (2)Learnt from: CR Learnt from: CR lib/features/key_manager/key_management_screen.dart (3)Learnt from: CR Learnt from: CR Learnt from: chebizarro lib/features/order/widgets/form_section.dart (4)Learnt from: CR Learnt from: CR Learnt from: CR Learnt from: CR lib/l10n/intl_it.arb (2)Learnt from: CR Learnt from: CR 🔇 Additional comments (24)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
grunch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary by CodeRabbit
New Features
Style
Documentation