-
Notifications
You must be signed in to change notification settings - Fork 16
Add zapstore spec file #302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughAdds a new zapstore.yaml manifest for the Mostro mobile app, defining app identity, metadata (name, summary, description, tags, license), links (repository, homepage), assets (icon, images, APK glob), and changelog reference. No source code or logic changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (4)
zapstore.yaml (4)
2-2: Consider pulling metadata automatically from GitHub/markets.Adding
remote_metadatalets Zapstore auto-fill name/summary/description/images from GitHub (and optionally Play/F-Droid), reducing drift. Keep your custom text if you want, but this helps long-term. (zapstore.dev)repository: https://github.com/mostroP2P/mobile +remote_metadata: + - github + # - playstore + # - fdroidAlso applies to: 5-22
23-30: Local icon/images: optionally pin Blossom servers.Icon/images are local paths; Zapstore uploads them to Blossom servers. If you want deterministic hosting or multiple mirrors, add
blossom_servers. Optional but improves asset availability. (zapstore.dev)icon: assets/images/launcher-icon.png images: - assets/images/screenshot-1.jpg - assets/images/screenshot-2.jpg - assets/images/screenshot-3.jpg - assets/images/screenshot-4.jpg - assets/images/screenshot-5.jpg +blossom_servers: + - https://cdn.zapstore.dev + # - https://blossom.band
33-34: APK glob is fine; sanity-check it doesn’t catch debug/nightly builds.The broad
.*.apkworks but may match unintended assets if your releases bundle multiple APKs. If that happens, narrow the regex (e.g.,-android-arm64-v8a\.apk). (zapstore.dev)
34-34: Add a newline at end of file.YAMLlint flagged missing EOF newline.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
zapstore.yaml(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.37.1)
zapstore.yaml
[error] 34-34: no new line character at the end of file
(new-line-at-end-of-file)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build
🔇 Additional comments (4)
zapstore.yaml (4)
24-24: Ensure CHANGELOG.md follows “Keep a Changelog” format.Zapstore parses release notes from Keep a Changelog; nonconforming files won’t extract correctly. (zapstore.dev)
31-31: Tags format looks good.Space-separated tags match Zapstore’s expected format. (zapstore.dev)
5-22: Validate security/feature claims in description.Claims like “NIP-59 gift wrapping,” “hardware-backed secure storage,” and “unique keys per trade (BIP-32/BIP-39)” should reflect shipped functionality; overselling in store metadata leads to trust issues. Please confirm or tone down.
1-1: Resolved — identifier matches applicationId; no change required.
identifier "network.mostro.app" matches android/app/build.gradle applicationId and the package/bundle IDs in the platform projects, so leaving or removing the field is optional.
Summary by CodeRabbit
Documentation
Chores