Skip to content

Conversation

@grunch
Copy link
Member

@grunch grunch commented Sep 13, 2025

Summary by CodeRabbit

  • Documentation

    • Added comprehensive app listing details (name, summary, description, homepage, repository) for storefront visibility.
    • Linked changelog for users to track updates.
  • Chores

    • Introduced a Zapstore manifest enabling distribution with icons, screenshots, and tags.
    • Declared license and platform support (Android) with APK asset configuration.
    • Included multilingual and feature highlights (privacy, Lightning, Nostr) in metadata for clearer user understanding.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 13, 2025

Walkthrough

Adds a new zapstore.yaml manifest for the Mostro mobile app, defining app identity, metadata (name, summary, description, tags, license), links (repository, homepage), assets (icon, images, APK glob), and changelog reference. No source code or logic changes.

Changes

Cohort / File(s) Summary of Changes
App manifest / metadata
zapstore.yaml
Introduces a 34-line ZapStore manifest with identifiers, links, descriptive metadata, images, tags, license, and asset pattern for APKs.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

I thump my paws on YAML ground,
A manifest found, concise and sound.
Icons shine, five screenshots gleam,
Tags like constellations beam.
No code to nudge, no tests to run—
Just metadata, neat and done.
Hop! Release prep has begun. 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "Add zapstore spec file" accurately and concisely captures the primary change in this PR — adding a zapstore manifest (zapstore.yaml) to the repository. It is a single clear sentence that directly reflects the file added in the diff. A reviewer scanning PR titles will understand the main purpose without needing further detail.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch add/zapstore

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (4)
zapstore.yaml (4)

2-2: Consider pulling metadata automatically from GitHub/markets.

Adding remote_metadata lets Zapstore auto-fill name/summary/description/images from GitHub (and optionally Play/F-Droid), reducing drift. Keep your custom text if you want, but this helps long-term. (zapstore.dev)

 repository: https://github.com/mostroP2P/mobile
+remote_metadata:
+  - github
+  # - playstore
+  # - fdroid

Also applies to: 5-22


23-30: Local icon/images: optionally pin Blossom servers.

Icon/images are local paths; Zapstore uploads them to Blossom servers. If you want deterministic hosting or multiple mirrors, add blossom_servers. Optional but improves asset availability. (zapstore.dev)

 icon: assets/images/launcher-icon.png
 images:
   - assets/images/screenshot-1.jpg
   - assets/images/screenshot-2.jpg
   - assets/images/screenshot-3.jpg
   - assets/images/screenshot-4.jpg
   - assets/images/screenshot-5.jpg
+blossom_servers:
+  - https://cdn.zapstore.dev
+  # - https://blossom.band

33-34: APK glob is fine; sanity-check it doesn’t catch debug/nightly builds.

The broad .*.apk works but may match unintended assets if your releases bundle multiple APKs. If that happens, narrow the regex (e.g., -android-arm64-v8a\.apk). (zapstore.dev)


34-34: Add a newline at end of file.

YAMLlint flagged missing EOF newline.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9994149 and 5f5491a.

📒 Files selected for processing (1)
  • zapstore.yaml (1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.37.1)
zapstore.yaml

[error] 34-34: no new line character at the end of file

(new-line-at-end-of-file)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build
🔇 Additional comments (4)
zapstore.yaml (4)

24-24: Ensure CHANGELOG.md follows “Keep a Changelog” format.

Zapstore parses release notes from Keep a Changelog; nonconforming files won’t extract correctly. (zapstore.dev)


31-31: Tags format looks good.

Space-separated tags match Zapstore’s expected format. (zapstore.dev)


5-22: Validate security/feature claims in description.

Claims like “NIP-59 gift wrapping,” “hardware-backed secure storage,” and “unique keys per trade (BIP-32/BIP-39)” should reflect shipped functionality; overselling in store metadata leads to trust issues. Please confirm or tone down.


1-1: Resolved — identifier matches applicationId; no change required.
identifier "network.mostro.app" matches android/app/build.gradle applicationId and the package/bundle IDs in the platform projects, so leaving or removing the field is optional.

@grunch grunch merged commit 08383f3 into main Sep 15, 2025
2 checks passed
@grunch grunch deleted the add/zapstore branch September 15, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants