-
Notifications
You must be signed in to change notification settings - Fork 16
fix: improve chat tab UI contrast, correct shared key display and correct status badge #320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughExtends Order.copyWith to include an optional Status. ChatRoomScreen now passes a copyWith(status: orderState.status) into TradeInformationTab. TradeInformationTab introduces a status chip via a new helper and localized labels. Info buttons adjust selected color and disable animation. Changes
Sequence Diagram(s)sequenceDiagram
actor User
participant ChatRoomScreen
participant TradeInformationTab
participant OrderState
participant StatusChip as _buildStatusChip
User->>ChatRoomScreen: Open chat room
ChatRoomScreen->>OrderState: Read current status
ChatRoomScreen->>TradeInformationTab: order.copyWith(status: OrderState.status)
TradeInformationTab->>StatusChip: Build chip for provided Status
StatusChip-->>TradeInformationTab: Chip widget (label + color)
TradeInformationTab-->>User: Updated trade info with status badge
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
en la descripcion del PR dice
Data Correction:
Fixed shared key display in User Information tab to show the correct private shared secret instead of derived public key
The shared key shown is now the actual NIP-44 computed shared secret used for message encryption/decryption
Pero no veo nada en los cambios de codigo que haga referencia a eso.
De todas formas ya la clave compartida que muetra es la privada, la que le pueden dar al admin para que lea lo que hablaron
@Catrya se me olvido quitar esa parte, paso que haciendo el detalle de la disputa me daba un dato raro en los logs, pero revise si esa trade key estaba bien y por lo que vi si, asi que no lo toque |
|
@AndreaDiazCorreia entonces para mí ya está bien, si puedes edita el mensaje del PR para que no quede esa parte que no está cambiada |
|
@Catrya listo |
Catrya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
grunch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bellorin
Changes
UI Improvements:
#1A1A1A) for better readabilityTesting
Status badge
Fixed an issue where the trade information tab in the chat screen displayed incorrect status badges. The tab was showing the original order status instead of the current state, causing canceled orders to appear as "active". Updated the Order model's copyWith method to accept status parameter and modified the chat screen to pass the current orderState.status, ensuring accurate status display across all order states including canceled, disputed, and completed orders.
Before:
After:
Summary by CodeRabbit