Support different opt-out messages per state #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1bc2542.
|
codygordon
reviewed
Feb 28, 2024
|
|
||
| lookup.zipCode = zip; | ||
|
|
||
| const res = await client.send(lookup); |
There was a problem hiding this comment.
just noting we do have a comprehensive static cache of zip to state seeded in the db (raw data), though there may be benefits to using the Smarty API?
Author
There was a problem hiding this comment.
Oh I didn't even realize this! The benefit of using the Smarty API is up-to-date data. But this is useful to know for future work if we or another org doesn't want to use Smarty API
codygordon
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows Spoke to be configured for unique opt-out-messages per state and org using the Smarty Streets API.
Checklist: