Skip to content

Fix excess orders stopping other orders' creation#1

Merged
MrRowey merged 1 commit into
MrRowey:uef-teleportfrom
lL1l1:UI/FixForTeleBilly
Nov 19, 2023
Merged

Fix excess orders stopping other orders' creation#1
MrRowey merged 1 commit into
MrRowey:uef-teleportfrom
lL1l1:UI/FixForTeleBilly

Conversation

@lL1l1
Copy link
Copy Markdown

@lL1l1 lL1l1 commented Nov 17, 2023

Solves the "strange bug" with tactical missile / billy nuke and teleport: FAForever#5679
First it wasn't creating the orders because 7 base orders + 3 engineering orders + 1 OC + 2 missile + 1 tele = 14, which is more than the 12 allowed to be created.
After fixing that, there is a bug where orders are created out of all available orders using limited order-assigned slots. This meant that it could grab a nil slot for an available order, since that order didn't get assigned in the slot checking beforehand. This is fixed with a nil check.
Ideally there would be a priority system for what orders are given slots, but that isn't worth the effort given how rarely you select units with enough orders to do that (needs cross-faction, cross-theater, and/or very expensive units).

@MrRowey MrRowey merged commit 6543345 into MrRowey:uef-teleport Nov 19, 2023
@lL1l1 lL1l1 deleted the UI/FixForTeleBilly branch December 6, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants