Strip BOM before processing records#23
Merged
shapiromatron merged 1 commit intoMrTango:masterfrom Apr 23, 2020
holub008:master
Merged
Strip BOM before processing records#23shapiromatron merged 1 commit intoMrTango:masterfrom holub008:master
shapiromatron merged 1 commit intoMrTango:masterfrom
holub008:master
Conversation
Collaborator
|
thanks @holub008! I'll wait on minting a new version unless you need it |
Contributor
Author
|
@shapiromatron Not a problem to wait - it's easy enough to implement the change in a forwards compatible way outside |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #13
Functional Changes
This change strips a BOM character, if present, from both the
load(file based) andloads(string based) entry points to the RIS parser.Testing
I added a new test case. I verified the test file includes a BOM character via:
hexdump -n 15 -C tests/data/example_bom.ris 00000000 ef bb bf 54 59 20 20 2d 20 4a 4f 55 52 0a 44 |...TY - JOUR.D| 0000000fRan tests via
make test(12/12 passed, whereas 11/12 passed before changes) and checked formatting viamake lint.