Add benchmark for rispy#65
Conversation
|
It might be a good idea to use a tool like pytest-benchmark when benchmarking pieces of code. That makes the benchmark results a bit more reliable, it will warm up your machine before running the benchmark, run it multiple times and calculate error margins based on that. |
|
Nice tool, I wanted to avoid introducing new dependencies, but this one looks worth it. I am happy to implement it now or later. Can the maintainers @shapiromatron @MrTango point us in the right direction? Btw, I published some results in PR #66. |
|
Let's implement now in this PR; that seems like a worthwhile dev dependency. Looking forward to this and the other PRs that you're queuing up! |
|
Thanks for the suggestion @PeterLombaers. Can you review @shapiromatron? I disabled the single tests for now as they mess up the comparison table a bit (us vs ms). |
shapiromatron
left a comment
There was a problem hiding this comment.
LGTM - I had two minor comments to address, but it looks fine, after those two comments are addressed.
|
Good, will fix this over the weekend. |
|
It feels ironic after you waited 6+ months for me to review this, but now that there's a little momentum, could you fix please when you have a moment? I'd like to cut a new release soon. Thank you! |
|
Done :) |
This PR introduces a simple benchmark tool for the performance of rispy. The benchmark consists of 10k identical records, which are parsed 100 times.
I will use this PR in an upcoming PR with performance improvements.
@holub008 @shapiromatron @PeterLombaers