Add support for Python 3.13 and remove Python 3.8 #67
Merged
shapiromatron merged 10 commits intoMrTango:mainfrom May 22, 2025
Merged
Add support for Python 3.13 and remove Python 3.8 #67shapiromatron merged 10 commits intoMrTango:mainfrom
shapiromatron merged 10 commits intoMrTango:mainfrom
Conversation
shapiromatron
requested changes
Apr 17, 2025
Collaborator
shapiromatron
left a comment
shapiromatron
left a comment
There was a problem hiding this comment.
This all looks great, thank you for the contribution! Happy to accept this, however I think we're about to accept some rather large changes with #66 over the next few days.
Would you be willing to update this PR after that has been merged in? All the changes look good to me.
Contributor
Author
|
@shapiromatron I have no problem waiting for the other PR to clear. Most of these changes are automatically created/fixed by the formatter. Just let me know. |
Collaborator
|
#66 was merged @dpgraham4401. We would love to review an update of this PR. |
dpgraham4401
force-pushed
the
add_python3.13_support
branch
from
c6d80a6 to
2de3ae5
Compare
Contributor
Author
|
@J535D165 @shapiromatron PR has been rebased and updated. |
J535D165
approved these changes
May 22, 2025
Collaborator
|
Nice, looks good to me. |
shapiromatron
approved these changes
May 22, 2025
Collaborator
There was a problem hiding this comment.
LGTM! Thank you for your contribution @dpgraham4401!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for Python version 3.13, removes support for Python 3.8 (which has reached EOL). It also updates the ruff version to the latest version (0.11.6 as of 04/2025) and the targeted python lint/formatting version to 3.9. Targeting 3.9+ allows us to use built-in collection types such as
listanddictas generic types instead of importing the corresponding capitalized types (e.g.ListorDict) from typing.EDIT: bumped the ruff version from 0.9.9 to 0.11.6