Skip to content

Conversation

@bonventre
Copy link
Contributor

For pruning extracted sims for single stations etc.

@FNALbuild
Copy link
Collaborator

Hi @bonventre,
You have proposed changes to files in these packages:

  • Filters

which require these tests: build.

@Mu2e/write, @Mu2e/fnalbuild-users have access to CI actions on main.

⌛ The following tests have been triggered for 1311cb0: build (Build queue - API unavailable)

About FNALbuild. Code review on Mu2e/Offline.

@FNALbuild
Copy link
Collaborator

☀️ The build tests passed at 1311cb0.

Test Result Details
test with Command did not list any other PRs to include
merge Merged 1311cb0 at 9aa90f4
build (prof) Log file. Build time: 04 min 34 sec
ceSimReco Log file.
g4test_03MT Log file.
transportOnly Log file.
POT Log file.
g4study Log file.
cosmicSimReco Log file.
cosmicOffSpill Log file.
ceSteps Log file.
ceDigi Log file.
muDauSteps Log file.
ceMix Log file.
rootOverlaps Log file.
g4surfaceCheck Log file.
trigger Log file.
check_cmake Log file. Return Code 1.
FIXME, TODO TODO (0) FIXME (0) in 1 files
clang-tidy 🔶 2 errors 1 warnings
whitespace check no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at 1311cb0 after being merged into the base branch at 9aa90f4.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

Copy link
Collaborator

@brownd1978 brownd1978 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine.
I'd encourage using a computed for loop to make it easier to read:
for(auto const& step : steps){
...

@oksuzian oksuzian merged commit a04e36a into Mu2e:main Jan 14, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants