feat(phase7a): stamp DISPOSITION_DEFERRED on batch submit#553
Merged
Muizzkolapo merged 6 commits intoMay 17, 2026
Merged
Conversation
Large workflows render too small to read because the mermaid SVG was constrained to max-width: 100% with no way to zoom in. Add interactive pan/zoom: mouse wheel to zoom, click-drag to pan, and control buttons (zoom in, zoom out, fit-to-view, reset). Auto-fits on first render.
…tion' into integration/batch-online-unification
…bmit U-3.3: After batch submission, DISPOSITION_DEFERRED must be stamped for every record sent to the provider. Currently no dispositions are written at submit time — only on retrieve. All 3 tests fail — proving the gap exists.
U-3.3: After successful batch submission, every INCLUDED record now gets DISPOSITION_DEFERRED written to the storage backend. Records that were filtered/skipped during preparation do not receive DEFERRED. Implementation: - Add storage_backend parameter to BatchSubmissionService - _stamp_deferred() iterates context_map for INCLUDED records - Both callers (initial_pipeline, workflow/pipeline) pass backend - Reason includes batch_id for traceability This enables operators to query the disposition table for in-flight batch records and lets Phase 7b clear DEFERRED on retrieve.
_stamp_deferred now uses _safe_set_disposition (matching all other callers) so a storage failure won't crash batch submission. Removed unused prepare_result parameter from test helper.
Verify that SKIPPED, FILTERED, and FAILED records do NOT receive DISPOSITION_DEFERRED — only INCLUDED records are stamped. Tests _stamp_deferred directly with a hand-crafted context_map containing all four FilterStatus values.
Muizzkolapo
merged commit 8666c07
into
integration/batch-online-unification
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
storage_backendparameter toBatchSubmissionServiceDISPOSITION_DEFERREDfor all INCLUDED records via new_stamp_deferred()methodinitial_pipeline._process_batch_mode,pipeline._handle_batch_generation) passstorage_backendbatch_idfor traceabilityVerification
tests/unit/unification/test_phase7a_deferred_disposition.py— all passruff format --checkandruff checkclean