Phase 9c: Filter/skip/observe consistency tests (U-4.3)#555
Merged
Muizzkolapo merged 3 commits intoMay 17, 2026
Merged
Conversation
TDD contract class TestFilteredNamespaceObserve plus filter/skip symmetry and fan-in interaction tests. 11 new tests verify that filtered and skipped namespaces produce identical null-safe observe behavior — all fields resolve to None instead of crashing. The behavioral implementation was completed in earlier work (PR #538 fan-in guard-filter null namespace + Phase 9a PR #554). These tests formalize the contract and lock the invariant: filter = skip for observe/passthrough resolution.
- Replace tautological test_filtered_and_skipped_resolve_identically (identical inputs proving f(x)==f(x)) with test_all_directives_null_safe that exercises observe+passthrough+drop on a filtered namespace - Replace tautological isinstance(dict) assertion in drop test with meaningful checks on prompt_context content - Fix invalid changie timestamp (09:c0 → 09:30) - Remove comments that restate assertions
Already covered by test_all_directives_null_safe_on_filtered (observe+passthrough+drop) and test_three_way_fan_in_one_filtered (fan-in layout). 10 tests remain.
Muizzkolapo
merged commit 7bf5f3b
into
integration/batch-online-unification
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestFilteredNamespaceObserve(U-4.3) plus filter/skip symmetry and fan-in interaction testsTest classes
Verification
pytest tests/unit/unification/test_phase9c_filter_skip_observe.py -v— 11 passedruff format --check— cleanruff check— cleanpytest— 6932 passed (3 pre-existing failures unrelated)