fix(phase-7b): batch retrieve disposition parity with online collector#557
Merged
Muizzkolapo merged 2 commits intoMay 17, 2026
Merged
Conversation
Tests verify batch retrieve dispositions match online ResultCollector rules (U-3.2a, U-3.5a): - SUCCESS records must get DISPOSITION_SUCCESS - FILTERED records must get DISPOSITION_FILTERED - EXHAUSTED must include input_snapshot - FAILED must include input_snapshot and detail - Prompt traces must only be written for SUCCESS records All 9 tests fail against current code, proving the parity gaps exist.
Closes U-3.2a and U-3.5a — batch retrieve dispositions now match online ResultCollector.collect_results() rules: - SUCCESS records get DISPOSITION_SUCCESS (previously only DEFERRED cleared) - FILTERED records get DISPOSITION_FILTERED via new _write_filtered_dispositions - EXHAUSTED dispositions include input_snapshot for forensics - FAILED dispositions include input_snapshot and detail - Prompt trace updates restricted to SUCCESS records only (tombstones excluded)
Muizzkolapo
force-pushed
the
unify/phase-7b-dispositions
branch
from
e893ec5 to
fba9a49
Compare
Muizzkolapo
merged commit d8c5684
into
integration/batch-online-unification
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ResultCollector.collect_results()rules (U-3.2a, U-3.5a)DISPOSITION_SUCCESS(previously only DEFERRED was cleared)DISPOSITION_FILTEREDvia new_write_filtered_dispositionsmethodinput_snapshotanddetailfor forensicsVerification
test_phase7b_disposition_parity.py(TDD: committed failing first, then green)test_async_evaluation_wiring.pyto expect newinput_snapshotfieldruff format+ruff checkclean