fix: PassthroughEnricher no longer mutates shared namespace dicts#563
Merged
Muizzkolapo merged 1 commit intoMay 19, 2026
Merged
Conversation
Muizzkolapo
force-pushed
the
fix/f11-passthrough-mutation
branch
from
d5516a8 to
75e1e3a
Compare
Replace ns.update() with dict spread to create a new dict per record. Prevents cross-record data contamination when multiple records share the same namespace dict object through shallow copies. Two regression tests verify isolation between records sharing a namespace dict, both across separate results and within the same result.
Muizzkolapo
force-pushed
the
fix/f11-passthrough-mutation
branch
from
75e1e3a to
994baa7
Compare
Muizzkolapo
changed the base branch from
main
to
integration/batch-online-unification
Muizzkolapo
merged commit fc8b456
into
integration/batch-online-unification
4 of 5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PassthroughEnricher.enrich()calledns.update(result.passthrough_fields)which mutates the namespace dict in-place. When multiple records share the same dict object through shallow copies (e.g.,RecordEnvelope.build_skipped), passthrough fields from one record leak into another.ns.update(...)withcontent[action_name] = {**ns, **result.passthrough_fields}— creates a new dict per record, eliminating cross-record contamination.enrichment.py, 2 regression tests added.Verification
ruff checkandruff format --checkclean