fix: write terminal disposition before clearing DEFERRED (F14)#564
Merged
Muizzkolapo merged 1 commit intoMay 19, 2026
Merged
Conversation
write_record_dispositions() previously called clear_disposition(DEFERRED) before set_disposition(terminal). A crash between the two left the record with no disposition — invisible to queries. Reorder: write the terminal disposition first, then clear DEFERRED. The UNIQUE(action_name, record_id, disposition) constraint allows both rows to coexist since disposition values differ. If the process crashes after the terminal write but before the DEFERRED clear, the terminal state is already committed and queryable. 6 regression tests verify the ordering invariant and crash-safety.
Muizzkolapo
force-pushed
the
fix/f14-atomic-disposition
branch
from
98007fa to
d16803c
Compare
Muizzkolapo
changed the base branch from
main
to
integration/batch-online-unification
Muizzkolapo
merged commit f3856af
into
integration/batch-online-unification
4 of 5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
write_record_dispositions()so the terminal disposition (FAILED, EXHAUSTED, FILTERED, etc.) is committed before clearing DEFERREDclear_disposition(DEFERRED)was called first — a crash between clear and write left the record with no disposition at all (invisible)(action_name, record_id, disposition)allows both rows to coexist since disposition values differVerification