fix: empty LLM response records no longer vanish from output (F10)#571
Merged
Muizzkolapo merged 2 commits intoMay 19, 2026
Merged
Conversation
When on_empty=warn (the default), an empty LLM response fell through to _transform_response producing data=[], which result_collector wrote as DISPOSITION_SUCCESS with zero output records — the record vanished. Now: on_empty=warn returns ProcessingResult.failed() so the record gets DISPOSITION_FAILED and is visible in error reporting. on_empty=skip returns ProcessingResult.skipped() with a tombstone so the record appears in output with a skip reason.
- Add EMPTY_OUTPUT to record/reasons.py (bare string violated module contract) - Remove logger.warning for on_empty=warn (RecordEmptyOutputEvent already fires) - Fix misleading "silently skip" comment — tombstone IS visible in output
Muizzkolapo
merged commit 5c380e0
into
integration/batch-online-unification
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
on_empty=warn(the default), an empty LLM response producedProcessingResult.success()withdata=[]. The result collector wroteDISPOSITION_SUCCESSbut added zero rows to output — the record silently vanished.on_empty=warnnow returnsProcessingResult.failed()so the record getsDISPOSITION_FAILEDand surfaces in error reporting.on_empty=skipnow returnsProcessingResult.skipped()with a tombstone record so it appears in output with a skip reason.on_empty=errorbehavior (still raisesEmptyOutputError).Verification
ruff checkandruff format --checkclean